[lmi-commits] [lmi] master f303642: Rework a failing command

[Greg Chicares]

branch: master
commit f3036427ff5e869e73b0c77d05c1f91a96c077f0
Author: Gregory W. Chicares <gchicares@sbcglobal.net>
Commit: Gregory W. Chicares <gchicares@sbcglobal.net>

    Rework a failing command
    
    This:
      git clone
      git submodule update --init
    resulted in
      fatal: not a git repository (or any of the parent directories): .git
    whereas manually running this:
      git clone
      cd subdir_created_by_git_clone
      git submodule update --init
    succeeded.
    
    The preceding commit (retained because it's valuable in itself) happened
    to work around this problem. The present commit resolves the problem.
    
    This alternative was tried:
    
        clone_opts="$coefficiency --recurse-submodules"
        git clone      "$clone_opts" git://git.savannah.nongnu.org/lmi.git \
          || [...similarly...]
    
    but it failed, with 'set -vx' output [one long line split to fit here]:
    
    + git clone --jobs=32 --recurse-submodules \
     git://git.savannah.nongnu.org/lmi.git
    error: option `jobs' expects a numerical value
    
    ...which seems to suggest fragility in git's command-line parser.
---
 install_msw.sh | 12 +++---------
 1 file changed, 3 insertions(+), 9 deletions(-)

diff --git a/install_msw.sh b/install_msw.sh
index f60eb3f..1ef767a 100755
--- a/install_msw.sh
+++ b/install_msw.sh
@@ -205,15 +205,9 @@ then
     # by a corporate firewall, fall back on https. In case a firewall
     # inexplicably blocks the gnu.org domain, try Vadim's github clone
     # as a last resort.
-
-    git clone git://git.savannah.nongnu.org/lmi.git \
-      || git clone https://git.savannah.nongnu.org/r/lmi.git \
-      || git clone https://github.com/vadz/lmi.git
-
-    # This could be replaced with --recurse-submodules option of git-clone,
-    # but do it in a separate command just to avoid repeating this option
-    # thrice above -- it's exactly the same thing, anyhow.
-    git submodule update --init
+    git clone      "$coefficiency" --recurse-submodules 
git://git.savannah.nongnu.org/lmi.git \
+      || git clone "$coefficiency" --recurse-submodules 
https://git.savannah.nongnu.org/r/lmi.git \
+      || git clone "$coefficiency" --recurse-submodules 
https://github.com/vadz/lmi.git
 fi
 
 cd /opt/lmi/src/lmi || printf 'Cannot cd\n'