[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[lmi-commits] [lmi] master 97a7a35 1/6: Improve variable names
From: |
Greg Chicares |
Subject: |
[lmi-commits] [lmi] master 97a7a35 1/6: Improve variable names |
Date: |
Wed, 12 Aug 2020 18:47:59 -0400 (EDT) |
branch: master
commit 97a7a35625c17c2f3f76694b4c4e7ea7768551b8
Author: Gregory W. Chicares <gchicares@sbcglobal.net>
Commit: Gregory W. Chicares <gchicares@sbcglobal.net>
Improve variable names
Searching for "round_loan" is fruitful. Searching for "loan" is futile.
---
rounding_document.cpp | 42 +++++++++++++++++++++---------------------
rounding_view.xrc | 42 +++++++++++++++++++++---------------------
2 files changed, 42 insertions(+), 42 deletions(-)
diff --git a/rounding_document.cpp b/rounding_document.cpp
index 299d393..21e4058 100644
--- a/rounding_document.cpp
+++ b/rounding_document.cpp
@@ -37,27 +37,27 @@ RoundingDocument::RoundingDocument()
,rounding_rules_ {}
,values_ {}
{
- values_["specamt" ] = &rounding_rules_.round_specamt_ ;
- values_["death_benefit" ] = &rounding_rules_.round_death_benefit_ ;
- values_["naar" ] = &rounding_rules_.round_naar_ ;
- values_["coi_rate" ] = &rounding_rules_.round_coi_rate_ ;
- values_["coi_charge" ] = &rounding_rules_.round_coi_charge_ ;
- values_["gross_premium" ] = &rounding_rules_.round_gross_premium_ ;
- values_["net_premium" ] = &rounding_rules_.round_net_premium_ ;
- values_["interest_rate" ] = &rounding_rules_.round_interest_rate_ ;
- values_["interest_credit" ] = &rounding_rules_.round_interest_credit_ ;
- values_["withdrawal" ] = &rounding_rules_.round_withdrawal_ ;
- values_["loan" ] = &rounding_rules_.round_loan_ ;
- values_["interest_rate_7702"] = &rounding_rules_.round_interest_rate_7702_;
- values_["corridor_factor" ] = &rounding_rules_.round_corridor_factor_ ;
- values_["nsp_rate_7702" ] = &rounding_rules_.round_nsp_rate_7702_ ;
- values_["seven_pay_rate" ] = &rounding_rules_.round_seven_pay_rate_ ;
- values_["surrender_charge" ] = &rounding_rules_.round_surrender_charge_ ;
- values_["irr" ] = &rounding_rules_.round_irr_ ;
- values_["min_specamt" ] = &rounding_rules_.round_min_specamt_ ;
- values_["max_specamt" ] = &rounding_rules_.round_max_specamt_ ;
- values_["min_premium" ] = &rounding_rules_.round_min_premium_ ;
- values_["max_premium" ] = &rounding_rules_.round_max_premium_ ;
+ values_["round_specamt" ] = &rounding_rules_.round_specamt_
;
+ values_["round_death_benefit" ] =
&rounding_rules_.round_death_benefit_ ;
+ values_["round_naar" ] = &rounding_rules_.round_naar_
;
+ values_["round_coi_rate" ] = &rounding_rules_.round_coi_rate_
;
+ values_["round_coi_charge" ] = &rounding_rules_.round_coi_charge_
;
+ values_["round_gross_premium" ] =
&rounding_rules_.round_gross_premium_ ;
+ values_["round_net_premium" ] = &rounding_rules_.round_net_premium_
;
+ values_["round_interest_rate" ] =
&rounding_rules_.round_interest_rate_ ;
+ values_["round_interest_credit" ] =
&rounding_rules_.round_interest_credit_ ;
+ values_["round_withdrawal" ] = &rounding_rules_.round_withdrawal_
;
+ values_["round_loan" ] = &rounding_rules_.round_loan_
;
+ values_["round_interest_rate_7702"] =
&rounding_rules_.round_interest_rate_7702_;
+ values_["round_corridor_factor" ] =
&rounding_rules_.round_corridor_factor_ ;
+ values_["round_nsp_rate_7702" ] =
&rounding_rules_.round_nsp_rate_7702_ ;
+ values_["round_seven_pay_rate" ] =
&rounding_rules_.round_seven_pay_rate_ ;
+ values_["round_surrender_charge" ] =
&rounding_rules_.round_surrender_charge_ ;
+ values_["round_irr" ] = &rounding_rules_.round_irr_
;
+ values_["round_min_specamt" ] = &rounding_rules_.round_min_specamt_
;
+ values_["round_max_specamt" ] = &rounding_rules_.round_max_specamt_
;
+ values_["round_min_premium" ] = &rounding_rules_.round_min_premium_
;
+ values_["round_max_premium" ] = &rounding_rules_.round_max_premium_
;
}
void RoundingDocument::ReadDocument(std::string const& filename)
diff --git a/rounding_view.xrc b/rounding_view.xrc
index ea4195f..8d561b0 100644
--- a/rounding_view.xrc
+++ b/rounding_view.xrc
@@ -57,7 +57,7 @@
</object>
<object class="sizeritem">
<flag>wxALIGN_LEFT</flag>
- <object class="RoundingButtons"
name="specamt">
+ <object class="RoundingButtons"
name="round_specamt">
</object>
</object>
<object class="sizeritem">
@@ -68,7 +68,7 @@
</object>
<object class="sizeritem">
<flag>wxALIGN_LEFT</flag>
- <object class="RoundingButtons"
name="death_benefit">
+ <object class="RoundingButtons"
name="round_death_benefit">
<size>-1,-1</size>
</object>
</object>
@@ -80,7 +80,7 @@
</object>
<object class="sizeritem">
<flag>wxALIGN_LEFT</flag>
- <object class="RoundingButtons"
name="naar">
+ <object class="RoundingButtons"
name="round_naar">
<size>-1,-1</size>
</object>
</object>
@@ -92,7 +92,7 @@
</object>
<object class="sizeritem">
<flag>wxALIGN_LEFT</flag>
- <object class="RoundingButtons"
name="coi_rate">
+ <object class="RoundingButtons"
name="round_coi_rate">
<size>-1,-1</size>
</object>
</object>
@@ -104,7 +104,7 @@
</object>
<object class="sizeritem">
<flag>wxALIGN_LEFT</flag>
- <object class="RoundingButtons"
name="coi_charge">
+ <object class="RoundingButtons"
name="round_coi_charge">
<size>-1,-1</size>
</object>
</object>
@@ -116,7 +116,7 @@
</object>
<object class="sizeritem">
<flag>wxALIGN_LEFT</flag>
- <object class="RoundingButtons"
name="gross_premium">
+ <object class="RoundingButtons"
name="round_gross_premium">
<size>-1,-1</size>
</object>
</object>
@@ -128,7 +128,7 @@
</object>
<object class="sizeritem">
<flag>wxALIGN_LEFT</flag>
- <object class="RoundingButtons"
name="net_premium">
+ <object class="RoundingButtons"
name="round_net_premium">
<size>-1,-1</size>
</object>
</object>
@@ -140,7 +140,7 @@
</object>
<object class="sizeritem">
<flag>wxALIGN_LEFT</flag>
- <object class="RoundingButtons"
name="interest_rate">
+ <object class="RoundingButtons"
name="round_interest_rate">
<size>-1,-1</size>
</object>
</object>
@@ -152,7 +152,7 @@
</object>
<object class="sizeritem">
<flag>wxALIGN_LEFT</flag>
- <object class="RoundingButtons"
name="interest_credit">
+ <object class="RoundingButtons"
name="round_interest_credit">
<size>-1,-1</size>
</object>
</object>
@@ -164,7 +164,7 @@
</object>
<object class="sizeritem">
<flag>wxALIGN_LEFT</flag>
- <object class="RoundingButtons"
name="withdrawal">
+ <object class="RoundingButtons"
name="round_withdrawal">
<size>-1,-1</size>
</object>
</object>
@@ -176,7 +176,7 @@
</object>
<object class="sizeritem">
<flag>wxALIGN_LEFT</flag>
- <object class="RoundingButtons"
name="loan">
+ <object class="RoundingButtons"
name="round_loan">
<size>-1,-1</size>
</object>
</object>
@@ -204,7 +204,7 @@
</object>
<object class="sizeritem">
<flag>wxALIGN_LEFT</flag>
- <object class="RoundingButtons"
name="interest_rate_7702">
+ <object class="RoundingButtons"
name="round_interest_rate_7702">
<size>-1,-1</size>
</object>
</object>
@@ -216,7 +216,7 @@
</object>
<object class="sizeritem">
<flag>wxALIGN_LEFT</flag>
- <object class="RoundingButtons"
name="corridor_factor">
+ <object class="RoundingButtons"
name="round_corridor_factor">
<size>-1,-1</size>
</object>
</object>
@@ -228,7 +228,7 @@
</object>
<object class="sizeritem">
<flag>wxALIGN_LEFT</flag>
- <object class="RoundingButtons"
name="nsp_rate_7702">
+ <object class="RoundingButtons"
name="round_nsp_rate_7702">
<size>-1,-1</size>
</object>
</object>
@@ -240,7 +240,7 @@
</object>
<object class="sizeritem">
<flag>wxALIGN_LEFT</flag>
- <object class="RoundingButtons"
name="seven_pay_rate">
+ <object class="RoundingButtons"
name="round_seven_pay_rate">
<size>-1,-1</size>
</object>
</object>
@@ -252,7 +252,7 @@
</object>
<object class="sizeritem">
<flag>wxALIGN_LEFT</flag>
- <object class="RoundingButtons"
name="surrender_charge">
+ <object class="RoundingButtons"
name="round_surrender_charge">
<size>-1,-1</size>
</object>
</object>
@@ -264,7 +264,7 @@
</object>
<object class="sizeritem">
<flag>wxALIGN_LEFT</flag>
- <object class="RoundingButtons" name="irr">
+ <object class="RoundingButtons"
name="round_irr">
<size>-1,-1</size>
</object>
</object>
@@ -276,7 +276,7 @@
</object>
<object class="sizeritem">
<flag>wxALIGN_LEFT</flag>
- <object class="RoundingButtons"
name="min_specamt">
+ <object class="RoundingButtons"
name="round_min_specamt">
<size>-1,-1</size>
</object>
</object>
@@ -288,7 +288,7 @@
</object>
<object class="sizeritem">
<flag>wxALIGN_LEFT</flag>
- <object class="RoundingButtons"
name="max_specamt">
+ <object class="RoundingButtons"
name="round_max_specamt">
<size>-1,-1</size>
</object>
</object>
@@ -300,7 +300,7 @@
</object>
<object class="sizeritem">
<flag>wxALIGN_LEFT</flag>
- <object class="RoundingButtons"
name="min_premium">
+ <object class="RoundingButtons"
name="round_min_premium">
<size>-1,-1</size>
</object>
</object>
@@ -312,7 +312,7 @@
</object>
<object class="sizeritem">
<flag>wxALIGN_LEFT</flag>
- <object class="RoundingButtons"
name="max_premium">
+ <object class="RoundingButtons"
name="round_max_premium">
<size>-1,-1</size>
</object>
</object>
- [lmi-commits] [lmi] master updated (26865ea -> e166864), Greg Chicares, 2020/08/12
- [lmi-commits] [lmi] master 97a7a35 1/6: Improve variable names,
Greg Chicares <=
- [lmi-commits] [lmi] master e166864 6/6: Round interest credit to separate account, Greg Chicares, 2020/08/12
- [lmi-commits] [lmi] master 8667bda 2/6: Add a rounding rule for minutiae, Greg Chicares, 2020/08/12
- [lmi-commits] [lmi] master 363ea40 3/6: Round specified-amount load, Greg Chicares, 2020/08/12
- [lmi-commits] [lmi] master 785e6f4 4/6: Round rider charges, Greg Chicares, 2020/08/12
- [lmi-commits] [lmi] master 7837f36 5/6: Fix defect introduced 20050114T1947Z: function call with no effect, Greg Chicares, 2020/08/12