[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[lmi-commits] [lmi] master 6863f5a 2/3: Fix defect introduced 20190515T1

From: Greg Chicares
Subject: [lmi-commits] [lmi] master 6863f5a 2/3: Fix defect introduced 20190515T1850Z: cygwin path quoting
Date: Wed, 29 Jul 2020 16:51:26 -0400 (EDT)

branch: master
commit 6863f5a894b5fa54c5d5d32e3592f30ccf87fec9
Author: Gregory W. Chicares <gchicares@sbcglobal.net>
Commit: Gregory W. Chicares <gchicares@sbcglobal.net>

    Fix defect introduced 20190515T1850Z: cygwin path quoting
    Commit 8f18ce94954d308 of 20190515T1850Z replaced double with single
    quotes, with the stated purpose of preventing a shellcheck warning.
    Reverted that change: shellcheck issues no warning for the reverted
    line (even with '--norc --enable=all'), and, more importantly, single
    quotes do not work here [lines split to keep commit message narrow]:
    $ PATH="/cygdrive/c/Program\ Files\ \(x86\)/Common\ Files/Oracle/Ja\
    va/javapath:$PATH" java -version
    java version [...]
    $ PATH='/cygdrive/c/Program\ Files\ \(x86\)/Common\ Files/Oracle/Ja\
    va/javapath:$PATH' java -version
    -bash: java: command not found
 install_msw.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/install_msw.sh b/install_msw.sh
index 362ee96..340c181 100755
--- a/install_msw.sh
+++ b/install_msw.sh
@@ -42,7 +42,7 @@ minimal_path=${MINIMAL_PATH:-"/usr/bin:/bin:/usr/sbin:/sbin"}
 case "$lmi_build_type" in
-        java_path='/cygdrive/c/Program\ Files\ \(x86\)/Common\ 
+        java_path="/cygdrive/c/Program\ Files\ \(x86\)/Common\ 
         minimal_path="$minimal_path:$(cygpath --sysdir):$java_path"

reply via email to

[Prev in Thread] Current Thread [Next in Thread]