[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[lmi-commits] [lmi] master a43eb0f 23/46: Add a comment explaining regis

From: Greg Chicares
Subject: [lmi-commits] [lmi] master a43eb0f 23/46: Add a comment explaining register_all() approach
Date: Wed, 22 Jul 2020 11:05:13 -0400 (EDT)

branch: master
commit a43eb0f238a0fd7e819fe05397f0821d6954c6d6
Author: Vadim Zeitlin <vadim@tt-solutions.com>
Commit: Vadim Zeitlin <vadim@tt-solutions.com>

    Add a comment explaining register_all() approach
    Leave a note explaining that this solution is chosen because it's much
    simpler (yet sufficient for our needs) than the other ones.
 census_view.cpp | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/census_view.cpp b/census_view.cpp
index ccc6815..6f0d6a7 100644
--- a/census_view.cpp
+++ b/census_view.cpp
@@ -1378,6 +1378,10 @@ class table_string_converter : public 
 table_custom_type_converter::register_all(wxGrid* grid)
+    // We could implement some kind of automatic registration, but it doesn't
+    // seem to be worth it for now, as we only have a few custom converters,
+    // all of which defined in this single file, so it's simpler to just list
+    // them explicitly here.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]