[lmi-commits] [lmi] master 4ecd4fe: Print a page number on the duplicate signature page

[Greg Chicares]

branch: master
commit 4ecd4fe5c5721c1fac41bd72f069008c216a3efc
Author: Gregory W. Chicares <address@hidden>
Commit: Gregory W. Chicares <address@hidden>

    Print a page number on the duplicate signature page
    
    NAIC drafted its illustration reg two decades ago, when illustrations
    were normally printed on paper. At that time, it made sense to print an
    extra copy of the prescribed numeric-summary-and-certification page, so
    that it could be signed and physically delivered to the insurer.
    
    Prior to this commit, that duplicate page has borne no page number, yet
    it has been included in the page count; thus, an illustration could
    consist of a (questionably) unnumbered cover page, then eight pages
    numbered "1 of 9" through "8 of 9"...and finally this unnumbered
    duplicate page, so that no page "9 of 9" exists and the illustration
    therefore seems incomplete. Now, the last page is numbered "9 of 9".
    
    Excluding the cover page, the now-retired XSL-FO code would have
    numbered the pages "1 of 8" through "8 of 8" in the example above, and
    labelled the duplicate final page "Attachment". It would alternatively
    have been okay to use that labelling scheme with wxPdfDoc illustrations,
    but that would constitute a major change. At first glance, it may appear
    that former class ill_reg_numeric_summary_attachment could simply be
    derived from class page_with_marginals (because it needs headers and
    footers), but then it wouldn't support an MST template, which requires
    derivation from class standard_page...which in turn derives from class
    numbered_page, but all numbered_page instances participate in the total
    page count.
---
 pdf_command_wx.cpp | 21 +++++----------------
 1 file changed, 5 insertions(+), 16 deletions(-)

diff --git a/pdf_command_wx.cpp b/pdf_command_wx.cpp
index c739ce4..bcdafce 100644
--- a/pdf_command_wx.cpp
+++ b/pdf_command_wx.cpp
@@ -1752,9 +1752,6 @@ TAGS_MODULE_BEGIN(lmi_illustration)
     TAGS_MODULE_ADD(unbreakable_paragraph)
 TAGS_MODULE_END(lmi_illustration)
 
-// Numeric summary page is used on its own, as a regular page, but also as the
-// base class for ill_reg_numeric_summary_attachment below, which is exactly
-// the same page, but appearing as an attachment at the end of the document.
 class ill_reg_numeric_summary_page : public standard_page
 {
   public:
@@ -1775,18 +1772,6 @@ class ill_reg_numeric_summary_page : public standard_page
     }
 };
 
-class ill_reg_numeric_summary_attachment : public ill_reg_numeric_summary_page
-{
-  public:
-    using ill_reg_numeric_summary_page::ill_reg_numeric_summary_page;
-
-  private:
-    std::string get_page_number() const override
-    {
-        return "Attachment";
-    }
-};
-
 // Helper base class for pages showing a table displaying values for all
 // contract years after some fixed content.
 class page_with_tabular_report
@@ -2330,9 +2315,13 @@ class pdf_illustration_naic : public pdf_illustration
             {
             add<ill_reg_supplemental_report>();
             }
+        // Add this again, even though it was already added above.
+        // Notionally, the purchaser detaches this duplicate paper
+        // page and mails it physically to the insurer. Someday a
+        // more modern alternative might be chosen.
         if(!invar.IsInforce)
             {
-            add<ill_reg_numeric_summary_attachment>();
+            add<ill_reg_numeric_summary_page>();
             }
     }