[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[lmi-commits] [lmi] master 7bf948b 8/8: Refactor for clarity
From: |
Greg Chicares |
Subject: |
[lmi-commits] [lmi] master 7bf948b 8/8: Refactor for clarity |
Date: |
Wed, 12 Sep 2018 12:08:06 -0400 (EDT) |
branch: master
commit 7bf948b591ffcc51cdd0cee5ad8281df713bfcdd
Author: Gregory W. Chicares <address@hidden>
Commit: Gregory W. Chicares <address@hidden>
Refactor for clarity
Swapped a couple lines; shortened a couple names.
---
ledger_pdf_generator_wx.cpp | 18 +++++++++---------
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/ledger_pdf_generator_wx.cpp b/ledger_pdf_generator_wx.cpp
index 42c998c..2810f29 100644
--- a/ledger_pdf_generator_wx.cpp
+++ b/ledger_pdf_generator_wx.cpp
@@ -353,14 +353,14 @@ class using_illustration_table
return false;
}
- std::vector<std::string> get_visible_values
+ std::vector<std::string> visible_values
(Ledger const& ledger
,html_interpolator const& interpolate_html
,int year
)
{
+ std::vector<std::string> v;
auto const& columns = get_table_columns();
- std::vector<std::string> visible_values;
for(int j = 0; j < lmi::ssize(columns); ++j)
{
columns[j].visibility =
@@ -384,10 +384,10 @@ class using_illustration_table
);
}
- visible_values.push_back(output_value);
+ v.push_back(output_value);
}
}
- return visible_values;
+ return v;
}
// Useful helper for creating the table generator using the columns defined
@@ -1501,13 +1501,13 @@ class numeric_summary_table_cell
case oe_render:
{
auto const& interpolate_html =
pdf_context_for_html_output.interpolate_html();
- auto visible_values = get_visible_values(ledger,
interpolate_html, year);
+ auto v = visible_values(ledger, interpolate_html, year);
if(is_last_row)
{
- visible_values.at(column_policy_year) =
summary_age_string;
+ v.at(column_policy_year) = summary_age_string;
}
- table_gen.output_row(pos_y, visible_values);
+ table_gen.output_row(pos_y, v);
}
break;
}
@@ -1640,8 +1640,8 @@ class page_with_tabular_report
for(;;)
{
- auto const visible_values = get_visible_values(ledger,
interpolate_html, year);
- table_gen.output_row(pos_y, visible_values);
+ auto const v = visible_values(ledger, interpolate_html, year);
+ table_gen.output_row(pos_y, v);
++year;
if(year == year_max)
- [lmi-commits] [lmi] master updated (d8aa128 -> 7bf948b), Greg Chicares, 2018/09/12
- [lmi-commits] [lmi] master 039924c 6/8: Refactor to prepare for a larger refactoring, Greg Chicares, 2018/09/12
- [lmi-commits] [lmi] master ff118b3 5/8: Assert that a refactoring will be safe, Greg Chicares, 2018/09/12
- [lmi-commits] [lmi] master 7bf948b 8/8: Refactor for clarity,
Greg Chicares <=
- [lmi-commits] [lmi] master 0d7d4d5 4/8: Simplify some special-case logic to make it easier to relocate, Greg Chicares, 2018/09/12
- [lmi-commits] [lmi] master 99930af 1/8: Declare a variable only in the scope where it's used, Greg Chicares, 2018/09/12
- [lmi-commits] [lmi] master 039c1fd 2/8: Declare a variable only in the scope where it's used, Greg Chicares, 2018/09/12
- [lmi-commits] [lmi] master a049a0d 3/8: Forestall latent off-by-one errors, Greg Chicares, 2018/09/12
- [lmi-commits] [lmi] master 1445c8d 7/8: Merge two identical blocks into a single function, Greg Chicares, 2018/09/12