[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[lmi-commits] [lmi] master 2c95260 07/12: Prefer 'switch' to 'if' for a
From: |
Greg Chicares |
Subject: |
[lmi-commits] [lmi] master 2c95260 07/12: Prefer 'switch' to 'if' for a two-valued enum |
Date: |
Tue, 22 May 2018 17:09:22 -0400 (EDT) |
branch: master
commit 2c95260480c9b872505e5a746bc242819571e0fb
Author: Gregory W. Chicares <address@hidden>
Commit: Gregory W. Chicares <address@hidden>
Prefer 'switch' to 'if' for a two-valued enum
---
wx_table_generator.cpp | 18 +++++++++++++-----
1 file changed, 13 insertions(+), 5 deletions(-)
diff --git a/wx_table_generator.cpp b/wx_table_generator.cpp
index 487feb0..df54d40 100644
--- a/wx_table_generator.cpp
+++ b/wx_table_generator.cpp
@@ -322,14 +322,22 @@ LMI_ASSERT(std::size_t(h / lh) == 1u +
count_newlines(z.header));
// output_headers() uses it to write all headers as a block.
increase_to_if_smaller(max_header_lines_, std::size_t(h / lh));
- // Also increase the column width to be sufficiently wide to fit
- // this header line if it is inelastic.
- if(oe_inelastic == z.elasticity)
+ switch(z.elasticity)
{
+ case oe_inelastic:
+ {
// Temporarily assert that this does the same as the code it replaced:
LMI_ASSERT(w == dc_.GetMultiLineTextExtent(z.header).x);
- increase_to_if_smaller(width, w);
- width += 2 * column_margin();
+ // Also increase the column width to be sufficiently wide to
fit
+ // this header line if it is inelastic.
+ increase_to_if_smaller(width, w);
+ width += 2 * column_margin();
+ }
+ break;
+ case oe_elastic:
+ {
+ }
+ break;
}
}
- [lmi-commits] [lmi] master updated (a1f29ab -> 40a94aa), Greg Chicares, 2018/05/22
- [lmi-commits] [lmi] master b219dd9 01/12: Note a possible future return-type change, Greg Chicares, 2018/05/22
- [lmi-commits] [lmi] master b725bcb 05/12: Reorder PDF column parameters, Greg Chicares, 2018/05/22
- [lmi-commits] [lmi] master 2c95260 07/12: Prefer 'switch' to 'if' for a two-valued enum,
Greg Chicares <=
- [lmi-commits] [lmi] master bd86afe 04/12: Shorten an enumerator's name, Greg Chicares, 2018/05/22
- [lmi-commits] [lmi] master 9e1ac25 09/12: Fold a "ternary" conditional into a switch, Greg Chicares, 2018/05/22
- [lmi-commits] [lmi] master 40a94aa 12/12: Explain why width of an elastic column is initialized to zero, Greg Chicares, 2018/05/22
- [lmi-commits] [lmi] master 6b93e91 11/12: Remove an unneeded auxiliary function, Greg Chicares, 2018/05/22
- [lmi-commits] [lmi] master b232274 02/12: Make column elasticity enumerative rather than boolean, Greg Chicares, 2018/05/22
- [lmi-commits] [lmi] master 7e64de5 03/12: Make column alignment enumerative rather than boolean, Greg Chicares, 2018/05/22
- [lmi-commits] [lmi] master e2e4ad6 08/12: Remove a temporary assertion that is no longer useful, Greg Chicares, 2018/05/22
- [lmi-commits] [lmi] master 637d535 06/12: Rework PDF column formatting in terms of "elasticity", Greg Chicares, 2018/05/22
- [lmi-commits] [lmi] master 6076b33 10/12: Simplify code; rewrite documentation, Greg Chicares, 2018/05/22