[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[lmi-commits] [lmi] master c665c1d 4/7: Refine documentation

From: Greg Chicares
Subject: [lmi-commits] [lmi] master c665c1d 4/7: Refine documentation
Date: Sat, 19 May 2018 12:54:40 -0400 (EDT)

branch: master
commit c665c1d8d6ca93e996e90d7cc380db29a7fc510a
Author: Gregory W. Chicares <address@hidden>
Commit: Gregory W. Chicares <address@hidden>

    Refine documentation
 wx_table_generator.cpp | 18 +++++++++++-------
 1 file changed, 11 insertions(+), 7 deletions(-)

diff --git a/wx_table_generator.cpp b/wx_table_generator.cpp
index dfc90a4..a5cb791 100644
--- a/wx_table_generator.cpp
+++ b/wx_table_generator.cpp
@@ -287,12 +287,15 @@ std::vector<wx_table_generator::column_info> const& 
 /// Indicate an intention to include a column by storing its metadata.
+/// Sets max_header_lines_.
 /// The total number of columns thus enrolled determines the cardinality
 /// of the 'values' argument in output_row() calls.
-/// Making a column hidden suppresses the column display, while still
-/// taking it into account in output_row(), providing a convenient way to
-/// hide a single column without changing the data representation.
+/// All data for every row and every potential column are passed into
+/// this class, even for "hidden" columns that are to be suppressed so
+/// that they don't appear in the output at all. This approach trades
+/// extra complexity here for a uniform data representation elsewhere.
 /// Each column must either have a fixed width, specified as the width of
 /// the longest text that may appear in this column, or be expandable
@@ -300,6 +303,9 @@ std::vector<wx_table_generator::column_info> const& 
 /// be the case if widest_text is empty.
 /// Notice that column headers may be multiline strings.
+/// Design alternative: this could be written as a nonmember function,
+/// by passing the DC and the header font as arguments.
 void wx_table_generator::enroll_column(column_parameters const& z)
@@ -318,10 +324,6 @@ void wx_table_generator::enroll_column(column_parameters 
const& z)
         // Set width to the special value of 0 for the variable width columns.
         width = z.widest_text.empty() ? 0 : dc_.GetTextExtent(z.widest_text).x;
-        // Keep track of the maximal number of lines in a header as this 
-        // the number of lines used for all of them. This is one plus the 
number of
-        // newlines in the anticipated case where there is no newline 
character at
-        // the beginning or end of the header's string representation.
         wxCoord w, h, lh;
         dc_.GetMultiLineTextExtent(z.header, &w, &h, &lh, &dc_.GetFont());
         LMI_ASSERT(0 != lh);
@@ -330,6 +332,8 @@ void wx_table_generator::enroll_column(column_parameters 
const& z)
 LMI_ASSERT(h / lh == int(1u + count_newlines(z.header)));
 // Check it again because of the unfortunate mixed-mode arithmetic:
 LMI_ASSERT(std::size_t(h / lh) == 1u + count_newlines(z.header));
+        // Store number of lines used by tallest unhidden header:
+        // output_headers() uses it to write all headers as a block.
         increase_to_if_smaller(max_header_lines_, std::size_t(h / lh));
         // Also increase the column width to be sufficiently wide to fit

reply via email to

[Prev in Thread] Current Thread [Next in Thread]