[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[lmi-commits] [lmi] master 7ffb9a9 5/5: Improve readability
From: |
Greg Chicares |
Subject: |
[lmi-commits] [lmi] master 7ffb9a9 5/5: Improve readability |
Date: |
Fri, 6 Apr 2018 21:41:38 -0400 (EDT) |
branch: master
commit 7ffb9a9304212155fef83ddb3f9105e485555f8a
Author: Gregory W. Chicares <address@hidden>
Commit: Gregory W. Chicares <address@hidden>
Improve readability
In a construct like:
coefficiency=${coefficiency:---jobs=4}
the shell knows that ':---' is really ':-' + '--', but that's not
necessarily obvious to humans who don't often write shell scripts.
---
install_wx.sh | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/install_wx.sh b/install_wx.sh
index 2b2a5bf..8045f69 100755
--- a/install_wx.sh
+++ b/install_wx.sh
@@ -23,12 +23,12 @@
# Configurable settings
########################################################
-wx_git_url=${wx_git_url:-https://github.com/wxWidgets/wxWidgets.git}
+wx_git_url=${wx_git_url:-"https://github.com/wxWidgets/wxWidgets.git"}
-wx_commit_sha=${wx_commit_sha:-41045df7ea5f93e4c07c1bd846d7127a372705bd}
+wx_commit_sha=${wx_commit_sha:-"41045df7ea5f93e4c07c1bd846d7127a372705bd"}
-coefficiency=${coefficiency:---jobs=4}
-MAKE=${MAKE:-make $coefficiency}
+coefficiency=${coefficiency:-"--jobs=4"}
+MAKE=${MAKE:-"make $coefficiency"}
# Variables that normally should be left alone
#################################