[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[lmi-commits] [lmi] master 49913fc 3/4: Sarculate and weed out redundant

From: Greg Chicares
Subject: [lmi-commits] [lmi] master 49913fc 3/4: Sarculate and weed out redundant repetition
Date: Thu, 1 Mar 2018 13:33:04 -0500 (EST)

branch: master
commit 49913fcd7e79ae647b0407bc704293f036d9b24a
Author: Gregory W. Chicares <address@hidden>
Commit: Gregory W. Chicares <address@hidden>

    Sarculate and weed out redundant repetition
    There actually is a serious reason for this simplification: it appears
    that some extra cleanup step might be wanted for input files provided
    by a certain third-party vendor, and the sanity-assertion function may
    suggest where to execute that step. Calling that function redundantly
    is of no practical consequence today because it is so lightweight, but
    repeating a costly extra step would impair responsiveness.
 multiple_cell_document.cpp | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/multiple_cell_document.cpp b/multiple_cell_document.cpp
index bd2eb67..a154214 100644
--- a/multiple_cell_document.cpp
+++ b/multiple_cell_document.cpp
@@ -61,14 +61,12 @@ multiple_cell_document::multiple_cell_document()
 /// Postconditions established by parse(): Case, class, and cell
 /// parameters are of sizes {==1, >=1, >=1) respectively.
-/// Calls assert_vector_sizes_are_sane() to assert the postconditions
-/// redundantly, even though they're established by parse().
+/// Postconditions: established by parse().
 multiple_cell_document::multiple_cell_document(std::string const& filename)
     xml_lmi::dom_parser parser(filename);
-    assert_vector_sizes_are_sane();
 /// Verify invariants.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]