lmi-commits
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[lmi-commits] [lmi] master 7e7069f 4/4: Resolve a marked defect: combine


From: Greg Chicares
Subject: [lmi-commits] [lmi] master 7e7069f 4/4: Resolve a marked defect: combine cases in switch [397]
Date: Mon, 20 Feb 2017 07:14:18 -0500 (EST)

branch: master
commit 7e7069fbbeeaf7f9a95e47419d9b287037068bc6
Author: Gregory W. Chicares <address@hidden>
Commit: Gregory W. Chicares <address@hidden>

    Resolve a marked defect: combine cases in switch [397]
    
    The removed comment seemed to suggest that other case-labels were
    followed by duplicate statements, but no other opportunities for
    such simplification were found.
---
 input_sequence_parser.cpp | 12 +-----------
 1 file changed, 1 insertion(+), 11 deletions(-)

diff --git a/input_sequence_parser.cpp b/input_sequence_parser.cpp
index 19c0162..b1acc0f 100644
--- a/input_sequence_parser.cpp
+++ b/input_sequence_parser.cpp
@@ -530,18 +530,8 @@ void SequenceParser::sequence()
                 {
                 return;
                 }
-            case e_major_separator:
-                {
-                match(current_token_type_);
-                if(e_eof == current_token_type_)
-                    {
-                    return;
-                    }
-                span();
-                }
-                break;
-// TODO ?? Superfluous. Same comment elsewhere. Fall through instead.
             case e_startup:
+            case e_major_separator:
                 {
                 match(current_token_type_);
                 if(e_eof == current_token_type_)



reply via email to

[Prev in Thread] Current Thread [Next in Thread]