lmi-commits
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[lmi-commits] [lmi] master 3e089d5 03/10: Fix defect introduced 20110801


From: Greg Chicares
Subject: [lmi-commits] [lmi] master 3e089d5 03/10: Fix defect introduced 20110801T2357Z: arguments omitted
Date: Mon, 6 Feb 2017 04:10:56 +0000 (UTC)

branch: master
commit 3e089d5c2604d661ffd6e9e83dc4e6adcf44d046
Author: Gregory W. Chicares <address@hidden>
Commit: Gregory W. Chicares <address@hidden>

    Fix defect introduced 20110801T2357Z: arguments omitted
    
    The two calls to the InputSequence ctor should both have supplied all
    available parameters. The last two were omitted in the case where an
    InputSequence is constructed for the sole purpose of obtaining its
    parser diagnostics. This seems clearly to have been a mere oversight.
    Apparently it would have caused incorrect behavior whenever the parser
    would give nonempty diagnostics only with the omitted information.
---
 input_sequence_entry.cpp |    2 ++
 1 file changed, 2 insertions(+)

diff --git a/input_sequence_entry.cpp b/input_sequence_entry.cpp
index ffdbb1f..18a1000 100644
--- a/input_sequence_entry.cpp
+++ b/input_sequence_entry.cpp
@@ -1217,6 +1217,8 @@ wxString InputSequenceEditor::get_diagnostics_message()
         ,input_.inforce_year     ()
         ,input_.effective_year   ()
         ,keywords_
+        ,keywords_only_
+        ,default_keyword_
         );
     std::string parser_diagnostics(sequence.formatted_diagnostics());
     rtrim(parser_diagnostics, "\n");



reply via email to

[Prev in Thread] Current Thread [Next in Thread]