[lmi-commits] [lmi] master eb8fbb6 1/5: Revert "Allow empty comments in rate tables"

[Greg Chicares]

branch: master
commit eb8fbb6274b85a211cce518731b70b01b6fe6861
Author: Gregory W. Chicares <address@hidden>
Commit: Gregory W. Chicares <address@hidden>

    Revert "Allow empty comments in rate tables"
    
    This reverts commit 1dae3a2a514388a5020df9a6e70ecc926856b8d2.
    
    Some historical files contained "Comments:  ". The change reverted here
    was enough to allow that, but removing the trailing blanks triggered
    another error:
      "value expected after 'Comments:'"
    It seems better to change those historical files rather than to keep
    modifying the code to ratify a disliked historical practice.
---
 rate_table.cpp |    4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/rate_table.cpp b/rate_table.cpp
index be523ad..5e4fd99 100644
--- a/rate_table.cpp
+++ b/rate_table.cpp
@@ -1299,9 +1299,7 @@ std::string* table_impl::parse_string
 {
     throw_if_duplicate_record(ostr.is_initialized(), field, line_num);
 
-    // With slight regret, allow the comments field to be empty because
-    // some historical files have put commentary in table name instead.
-    if(value.empty() && e_field_comments != field)
+    if(value.empty())
         {
         fatal_error()
             << "non-empty value must be specified for the field '"