[lmi-commits] [6328] Replace an idiosyncratic interface; remove its unit test

[Greg Chicares]

Revision: 6328
          http://svn.sv.gnu.org/viewvc/?view=rev&root=lmi&revision=6328
Author:   chicares
Date:     2015-10-07 19:47:46 +0000 (Wed, 07 Oct 2015)
Log Message:
-----------
Replace an idiosyncratic interface; remove its unit test

Modified Paths:
--------------
    lmi/trunk/ledger_xml_io.cpp
    lmi/trunk/wx_test_validate_output.cpp

Modified: lmi/trunk/ledger_xml_io.cpp
===================================================================
--- lmi/trunk/ledger_xml_io.cpp 2015-10-07 12:43:22 UTC (rev 6327)
+++ lmi/trunk/ledger_xml_io.cpp 2015-10-07 19:47:46 UTC (rev 6328)
@@ -961,10 +961,7 @@
     x.push_back(data);
     x.push_back(supplementalreport);
 
-    if
-        (   is_composite()
-        &&  contains(ledger_invariant_->Comments, "idiosyncrasy_spreadsheet")
-        )
+    if(is_composite() && contains(global_settings::instance().pyx(), 
"values_tsv"))
         {
         throw_if_interdicted(*this);
 

Modified: lmi/trunk/wx_test_validate_output.cpp
===================================================================
--- lmi/trunk/wx_test_validate_output.cpp       2015-10-07 12:43:22 UTC (rev 
6327)
+++ lmi/trunk/wx_test_validate_output.cpp       2015-10-07 19:47:46 UTC (rev 
6328)
@@ -330,46 +330,6 @@
         );
 }
 
-void validate_print_case_pdf_output
-        (std::string const& corp_name
-        ,std::string const& insured_name
-        )
-{
-    wxUIActionSimulator ui;
-
-    ui.Char('e', wxMOD_CONTROL | wxMOD_SHIFT); // "Census|Edit case defaults"
-    wxTEST_DIALOG
-        (wxYield()
-        ,enter_comments_in_case_defaults_dialog("idiosyncrasy_spreadsheet")
-        ,wxExpectModal<wxMessageDialog>(wxYES).
-            Describe("message box asking whether to apply changes to all 
cells")
-        );
-
-    ui.Char('s', wxMOD_CONTROL); // "File|Save"
-
-    fs::path values_file(configurable_settings::instance().print_directory());
-    values_file /= "values" + tsv_ext();
-
-    output_file_existence_checker output_values(values_file);
-
-    // We don't really care about these files existence, but we don't want them
-    // to be left over after the end of this test, so use the output existence
-    // checker helper to ensure that they are cleaned up.
-    output_pdf_existence_checker
-         composite_pdf(corp_name + ".composite" + serial_suffix(0))
-        ,first_cell_pdf(corp_name + "." + insured_name + serial_suffix(1))
-        ,second_cell_pdf(corp_name + serial_suffix(2))
-        ;
-
-    ui.Char('i', wxMOD_CONTROL | wxMOD_SHIFT); // "Census|Print case to PDF"
-    wxYield();
-
-    LMI_ASSERT_WITH_MSG
-        (output_values.exists()
-        ,"file \"" << values_file << "\" after print case to PDF"
-        );
-}
-
 void validate_run_cell_and_copy_output
         (std::string const& corp_name
         ,std::string const& insured_name
@@ -469,14 +429,6 @@
 //    ABC.cns.roster.tsv
 /// ...and delete all three now.
 ///
-/// Census | Edit case defaults
-///   Comments: replace contents with "idiosyncrasy_spreadsheet"
-///   OK
-///   Yes (apply to all)
-/// Census | Print case to PDF
-/// Verify that this file was created:
-///   values.tsv
-///
 /// select the "John Brown" cell
 /// Census | Run cell
 /// Illustration | Copy full illustration data [Ctrl-D]
@@ -575,7 +527,6 @@
     validate_print_case_output(corp_name, insured_filename);
     validate_print_roster_output(corp_name, insured_filename);
 
-    validate_print_case_pdf_output(corp_name, insured_filename);
     validate_run_cell_and_copy_output(corp_name, insured_filename);
 
     census.close();