[lmi-commits] [6182] Fix defect introduced 20050114T1947Z

[Greg Chicares]

Revision: 6182
          http://svn.sv.gnu.org/viewvc/?view=rev&root=lmi&revision=6182
Author:   chicares
Date:     2015-05-02 14:09:23 +0000 (Sat, 02 May 2015)
Log Message:
-----------
Fix defect introduced 20050114T1947Z

Modified Paths:
--------------
    lmi/trunk/ChangeLog
    lmi/trunk/ihs_avmly.cpp

Modified: lmi/trunk/ChangeLog
===================================================================
--- lmi/trunk/ChangeLog 2015-05-02 00:42:51 UTC (rev 6181)
+++ lmi/trunk/ChangeLog 2015-05-02 14:09:23 UTC (rev 6182)
@@ -36149,3 +36149,35 @@
 Remove redundant wxALIGN_LEFT flags from horizontal wxBoxSizer. See:
   http://lists.nongnu.org/archive/html/lmi/2015-04/msg00012.html
 
+20150501T2349Z <address@hidden> [516]
+
+  ihs_avmly.cpp
+Mark some taxation issues.
+
+20150502T0025Z <address@hidden> [516]
+
+  ihs_acctval.cpp
+Improve documentation.
+
+20150502T0036Z <address@hidden> [514]
+
+  ihs_acctval.cpp
+  ihs_avmly.cpp
+Resolve two marked defects: improve initialization and documentation.
+
+20150502T0042Z <address@hidden> [514]
+
+  ihs_avmly.cpp
+Remove a latent defect.
+
+20150502T1409Z <address@hidden> [513]
+
+  ihs_avmly.cpp
+Fix defect introduced 20050114T1947Z, from an original file predating
+the lmi epoch. Maximum loan and withdrawal were overstated for group
+UL plans when ee mode was more frequent than er mode. This situation
+is unlikely to arise. If it ever did arise, the distortion would not
+matter much: the intention is to prevent lapse, which wouldn't occur
+anyway because of the ee payment, so the admin system would simply
+have an unneeded extra margin of conservatism.
+

Modified: lmi/trunk/ihs_avmly.cpp
===================================================================
--- lmi/trunk/ihs_avmly.cpp     2015-05-02 00:42:51 UTC (rev 6181)
+++ lmi/trunk/ihs_avmly.cpp     2015-05-02 14:09:23 UTC (rev 6182)
@@ -704,12 +704,14 @@
     return 0 == Month % (12 / mode);
 }
 
-//============================================================================
+/// Number of monthiversaries before next billing date, counting today.
+///
+/// This is intended for use only with group UL plans, so it reflects
+/// the group billing mode chosen by the employer.
+
 int AccountValue::MonthsToNextModalPmtDate() const
 {
-    // TODO ?? Answer is in terms of *ee* mode only, but it seems
-    // wrong to ignore *er* mode.
-    return 1 + (11 - Month) % (12 / InvariantValues().EeMode[Year].value());
+    return 1 + (11 - Month) % (12 / InvariantValues().ErMode[Year].value());
 }
 
 /// Determine instantaneous base-policy minimum specified amount.