[lmi-commits] [6009] Remove a too-fleeting progress meter

[Greg Chicares]

Revision: 6009
          http://svn.sv.gnu.org/viewvc/?view=rev&root=lmi&revision=6009
Author:   chicares
Date:     2014-10-30 12:10:23 +0000 (Thu, 30 Oct 2014)
Log Message:
-----------
Remove a too-fleeting progress meter

Modified Paths:
--------------
    lmi/trunk/ChangeLog
    lmi/trunk/skeleton.cpp

Modified: lmi/trunk/ChangeLog
===================================================================
--- lmi/trunk/ChangeLog 2014-10-29 18:47:27 UTC (rev 6008)
+++ lmi/trunk/ChangeLog 2014-10-30 12:10:23 UTC (rev 6009)
@@ -34463,3 +34463,10 @@
 wxView::OnUpdate(): just say "no". See:
   http://lists.nongnu.org/archive/html/lmi/2014-10/msg00105.html
 
+20141030T1210Z <address@hidden> [528]
+
+  skeleton.cpp
+Remove a too-fleeting progress meter. See:
+  http://lists.nongnu.org/archive/html/lmi/2014-10/msg00103.html
+  http://lists.nongnu.org/archive/html/lmi/2014-10/msg00117.html
+

Modified: lmi/trunk/skeleton.cpp
===================================================================
--- lmi/trunk/skeleton.cpp      2014-10-29 18:47:27 UTC (rev 6008)
+++ lmi/trunk/skeleton.cpp      2014-10-30 12:10:23 UTC (rev 6009)
@@ -73,7 +73,6 @@
 #include "policy_view.hpp"
 #include "preferences_model.hpp"
 #include "preferences_view.hpp"
-#include "progress_meter.hpp"
 #include "rounding_document.hpp"
 #include "rounding_view.hpp"
 #include "rounding_view_editor.hpp"     // RoundingButtonsXmlHandler
@@ -106,7 +105,6 @@
 #include <sstream>
 #include <stdexcept>
 #include <string>
-#include <vector>
 
 #if defined __WXGTK__
 #   include <gtk/gtk.h>
@@ -1317,13 +1315,9 @@
     return true;
 }
 
-// TODO ?? CALCULATION_SUMMARY Instead, why not just update the
-// topmost window first, then update other windows, putting some
-// progress indication on the statusbar?
-
 void Skeleton::UpdateViews()
 {
-    std::vector<IllustrationView*> ivv;
+    wxBusyCursor wait;
     wxWindowList const& wl = frame_->GetChildren();
     for(wxWindowList::const_iterator i = wl.begin(); i != wl.end(); ++i)
         {
@@ -1333,26 +1327,9 @@
             IllustrationView* v = 
dynamic_cast<IllustrationView*>(c->GetView());
             if(v)
                 {
-                ivv.push_back(v);
+                v->DisplaySelectedValuesAsHtml();
                 }
             }
         }
-
-    boost::shared_ptr<progress_meter> meter
-        (create_progress_meter
-            (ivv.size()
-            ,"Updating calculation summaries"
-            )
-        );
-    typedef std::vector<IllustrationView*>::const_iterator vvci;
-    for(vvci i = ivv.begin(); i != ivv.end(); ++i)
-        {
-        (*i)->DisplaySelectedValuesAsHtml();
-        if(!meter->reflect_progress())
-            {
-            break;
-            }
-        }
-    meter->culminate();
 }