[lmi-commits] [5499] Make private functions of class glossed_string public

[Greg Chicares]

Revision: 5499
          http://svn.sv.gnu.org/viewvc/?view=rev&root=lmi&revision=5499
Author:   chicares
Date:     2012-06-17 10:08:26 +0000 (Sun, 17 Jun 2012)
Log Message:
-----------
Make private functions of class glossed_string public

Modified Paths:
--------------
    lmi/trunk/ChangeLog
    lmi/trunk/product_data.cpp
    lmi/trunk/product_data.hpp

Modified: lmi/trunk/ChangeLog
===================================================================
--- lmi/trunk/ChangeLog 2012-06-16 21:50:27 UTC (rev 5498)
+++ lmi/trunk/ChangeLog 2012-06-17 10:08:26 UTC (rev 5499)
@@ -30293,7 +30293,7 @@
   product_data.hpp
 Rename certain variables.
 
-20120616T1209Z <address@hidden> [578]
+20120616T1210Z <address@hidden> [578]
 
   antediluvian_stubs.cpp
   product_data.cpp
@@ -30302,3 +30302,17 @@
 intended redintegration does not take place, because detritus_map
 holds a std::string rather than a glossed_string.
 
+20120616T2150Z <address@hidden> [578]
+
+  xml_serializable.hpp
+  xml_serializable.tpp
+Distinguish deserialized value type from std::string.
+
+20120617T1008Z <address@hidden> [578]
+
+  product_data.cpp
+  product_data.hpp
+Make private functions of class glossed_string public, so that it can
+be stored in a map (supra, at 20120616T1210Z). Privacy had been simply
+a default choice that afforded no important protective value.
+

Modified: lmi/trunk/product_data.cpp
===================================================================
--- lmi/trunk/product_data.cpp  2012-06-16 21:50:27 UTC (rev 5498)
+++ lmi/trunk/product_data.cpp  2012-06-17 10:08:26 UTC (rev 5499)
@@ -99,8 +99,6 @@
     throw "Unreachable--silences a compiler diagnostic.";
 }
 
-/// Private default ctor, for friend class product_data.
-
 glossed_string::glossed_string()
 {}
 
@@ -115,8 +113,6 @@
 glossed_string::~glossed_string()
 {}
 
-/// Temporary private assignment operator for external 'my_prod.cpp'.
-
 glossed_string& glossed_string::operator=(std::string const& s)
 {
     datum_ = s;
@@ -287,7 +283,7 @@
 /// Backward-compatibility serial number of this class's xml version.
 ///
 /// version 0: 20100402T1123Z
-/// version 1: 20120616T1209Z
+/// version 1: 20120616T1210Z
 
 int product_data::class_version() const
 {

Modified: lmi/trunk/product_data.hpp
===================================================================
--- lmi/trunk/product_data.hpp  2012-06-16 21:50:27 UTC (rev 5498)
+++ lmi/trunk/product_data.hpp  2012-06-17 10:08:26 UTC (rev 5499)
@@ -46,24 +46,23 @@
     :virtual private obstruct_slicing<glossed_string>
 {
     friend class PolicyDocument;
-    friend class product_data;
 
   public:
+    glossed_string();
     explicit glossed_string
         (std::string const& datum
         ,std::string const& gloss = std::string()
         );
     ~glossed_string();
 
+    glossed_string& operator=(std::string const&);
+
     bool operator==(glossed_string const&) const;
 
     std::string const& datum() const;
     std::string const& gloss() const;
 
   private:
-    glossed_string();
-    glossed_string& operator=(std::string const&);
-
     std::string datum_;
     std::string gloss_;
 };