[Linphone-users] FTBS: linphone-3.7.0 coreapi/bellesip_sal/sal_sdp.c:377:4: error: expected '; ' before 'pt'

[J G Miller]

I have downloaded the source file tar ball for linphone 3.7.0linphone 3.7.0 and 
have encountered a fatal compilation error
in linphone-3.7.0/coreapi/bellesip_sal/sal_sdp.c line 377

  CC       bellesip_sal/sal_sdp.lo
bellesip_sal/sal_sdp.c: In function 'sdp_to_media_description':
bellesip_sal/sal_sdp.c:377:4: error: expected ';' before 'pt'
    pt=payload_type_new();
    ^
bellesip_sal/sal_sdp.c:395:3: error: implicit declaration of function 
'belle_sdp_attribute_get_value' [-Werror=implicit-function-declaration]
   if (attribute && (value=belle_sdp_attribute_get_value(attribute))!=NULL){
   ^
bellesip_sal/sal_sdp.c:395:26: error: assignment makes pointer from integer 
without a cast [-Werror]
   if (attribute && (value=belle_sdp_attribute_get_value(attribute))!=NULL){
                          ^
bellesip_sal/sal_sdp.c:416:128: error: comparison between pointer and integer 
[-Werror]
     if ( keywordcmp ( "crypto",belle_sdp_attribute_get_name ( attribute ) ) 
==0 && belle_sdp_attribute_get_value ( attribute ) !=NULL ) {
                                                                                
                                                ^
bellesip_sal/sal_sdp.c:420:11: error: passing argument 1 of 'sscanf' makes 
pointer from integer without a cast [-Werror]
           tmp2 );
           ^
In file included from /usr/include/features.h:371:0,
                 from /usr/include/errno.h:28,
                 from ../oRTP/include/ortp/port.h:30,
                 from ../oRTP/include/ortp/logging.h:29,
                 from ../mediastreamer2/include/mediastreamer2/mscommon.h:22,
                 from ../include/sal/sal.h:33,
                 from bellesip_sal/sal_impl.h:23,
                 from bellesip_sal/sal_sdp.c:19:
/usr/include/stdio.h:448:12: note: expected 'const char * __restrict__' but 
argument is of type 'int'
 extern int __REDIRECT_NTH (sscanf, (const char *__restrict __s,
            ^
bellesip_sal/sal_sdp.c:444:7: error: format '%s' expects argument of type 'char 
*', but argument 2 has type 'int' [-Werror=format=]
       ms_warning ( "sdp has a strange a= line (%s) 
nb=%i",belle_sdp_attribute_get_value ( attribute ),nb );
       ^
bellesip_sal/sal_sdp.c:456:9: error: assignment makes pointer from integer 
without a cast [-Werror]
    value=belle_sdp_attribute_get_value(attribute);
         ^
cc1: all warnings being treated as errors
make[4]: *** [bellesip_sal/sal_sdp.lo] Error 1
make[4]: Leaving directory `/home/Temp/Build/linphone-3.7.0/coreapi'
make[3]: *** [all-recursive] Error 1
make[3]: Leaving directory `/home/Temp/Build/linphone-3.7.0/coreapi'
make[2]: *** [all] Error 2
make[2]: Leaving directory `/home/Temp/Build/linphone-3.7.0/coreapi'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/home/Temp/Build/linphone-3.7.0'
make: *** [all] Error 2

The previous non-blank line is

                        mime_param=BELLE_SDP_MIME_PARAMETER ( 
mime_param_it->data )

It would appear that there is a semi-colon missing from the end of this line.

Adding a semi-colon then allows compilation to continue until

  CC       bellesip_sal/sal_sdp.lo
bellesip_sal/sal_sdp.c: In function 'sdp_to_media_description':
bellesip_sal/sal_sdp.c:395:3: error: implicit declaration of function 
'belle_sdp_attribute_get_value' [-Werror=implicit-function-declaration]
   if (attribute && (value=belle_sdp_attribute_get_value(attribute))!=NULL){
   ^
bellesip_sal/sal_sdp.c:395:26: error: assignment makes pointer from integer 
without a cast [-Werror]
   if (attribute && (value=belle_sdp_attribute_get_value(attribute))!=NULL){
                          ^
bellesip_sal/sal_sdp.c:416:128: error: comparison between pointer and integer 
[-Werror]
     if ( keywordcmp ( "crypto",belle_sdp_attribute_get_name ( attribute ) ) 
==0 && belle_sdp_attribute_get_value ( attribute ) !=NULL ) {
                                                                                
                                                ^
bellesip_sal/sal_sdp.c:420:11: error: passing argument 1 of 'sscanf' makes 
pointer from integer without a cast [-Werror]
           tmp2 );
           ^
In file included from /usr/include/features.h:371:0,
                 from /usr/include/errno.h:28,
                 from ../oRTP/include/ortp/port.h:30,
                 from ../oRTP/include/ortp/logging.h:29,
                 from ../mediastreamer2/include/mediastreamer2/mscommon.h:22,
                 from ../include/sal/sal.h:33,
                 from bellesip_sal/sal_impl.h:23,
                 from bellesip_sal/sal_sdp.c:19:
/usr/include/stdio.h:448:12: note: expected 'const char * __restrict__' but 
argument is of type 'int'
 extern int __REDIRECT_NTH (sscanf, (const char *__restrict __s,
            ^
bellesip_sal/sal_sdp.c:444:7: error: format '%s' expects argument of type 'char 
*', but argument 2 has type 'int' [-Werror=format=]
       ms_warning ( "sdp has a strange a= line (%s) 
nb=%i",belle_sdp_attribute_get_value ( attribute ),nb );
       ^
bellesip_sal/sal_sdp.c:456:9: error: assignment makes pointer from integer 
without a cast [-Werror]
    value=belle_sdp_attribute_get_value(attribute);
         ^
cc1: all warnings being treated as errors
make[4]: *** [bellesip_sal/sal_sdp.lo] Error 1
make[4]: Leaving directory `/home/Temp/Build/linphone-3.7.0/coreapi'
make[3]: *** [all-recursive] Error 1
make[3]: Leaving directory `/home/Temp/Build/linphone-3.7.0/coreapi'
make[2]: *** [all] Error 2
make[2]: Leaving directory `/home/Temp/Build/linphone-3.7.0/coreapi'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/home/Temp/Build/linphone-3.7.0'
make: *** [all] Error 2


Please advise how this fatal error can be rectified?


Also, do any of the Linphone Development Team EVER actually try to compile and 
test
these official released source tar archives?