|
Thank you for the clarification. However the problem remains. If this warning is treated as an error we are stuck. I suppose CMakeLists.txt
or Makefile could be edited to work around it. That doesn't solve it for the next person. It should be fixed at Belledonne. Just my opinion.
Rob D
On Sunday, July 29, 2018 1:51:44 PM PDT Nick Briggs wrote:
GCC 8 introduced the -Wstringop-truncation because failure to NUL terminate strings as a result of a "strncpy(dest, src, sizeof(dest))" often leads to later code wandering off the end of the unterminated destination string. strncpy()'s definition and behavior hasn't changed.
There's an article on it at https://developers.redhat.com/blog/2018/05/24/detecting-string-truncation-with-gcc-8/
I believe that the folks at Belledonne Communications do monitor this list.
-- Nick Briggs
On Jul 29, 2018, at 1:01 PM, Robert Dyck <address@hidden> wrote:
I believe it is due to a change in the C standard library. The warning means
that the new version of the function may truncate the string. This triggers a
warning. The linphone build system treats warnings as errors. I tried setting
"enable_strict" to no but it didn't help. cmake said it was an unused option.
I have my doubts that the developers monitor this list.
Rob D
On Sunday, July 29, 2018 12:31:34 PM PDT Bernd Kuhls wrote:
Am Sun, 17 Jun 2018 14:22:29 -0700 schrieb Robert Dyck:
Dear developers, FYI
Source is from git as June 17.
[ 29%] Building C object src/CMakeFiles/mediastreamer_voip.dir/
audiofilters/
tonedetector.c.o
*/home/rdyck/Downloads/linphone-desktop/submodules/mediastreamer2/src/
audiofilters/tonedetector.c:* In function ‘*detector_process*’:
*/home/rdyck/Downloads/linphone-desktop/submodules/mediastreamer2/src/
audiofilters/tonedetector.c:176:8:* *error: *‘*strncpy*’ specified
bound 8 equals
destination size [*-Werror=stringop-trunca*
]
*strncpy(event.tone_name,tone_def->tone_name,sizeof(event.tone_name))*;
Hi,
same here while building linphone-desktop for linux with git master HEAD
after updating Debian testing to gcc8.
Regards, Bernd
_______________________________________________
Linphone-developers mailing list
address@hidden
https://lists.nongnu.org/mailman/listinfo/linphone-developers
_______________________________________________
Linphone-developers mailing list
address@hidden
https://lists.nongnu.org/mailman/listinfo/linphone-developers
|