[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Linphone-developers] [Mail 1/3][PATCH] mediastreamer2: audio qualit

From: bagamarco .
Subject: Re: [Linphone-developers] [Mail 1/3][PATCH] mediastreamer2: audio quality, tool/mediastreamer feature and minor changes
Date: Mon, 12 Feb 2018 15:25:49 +0100

Thomas Dalmayrac report a paste/copy error. Attached fixed patch 0003-audiofilters-alsa-fixed-reference-errors-when-compil.patch replaces previous one.

2018-02-12 15:00 GMT+01:00 Thomas Dalmayrac <address@hidden>:

Hi !

In 0003-audiofilters-alsa-fixed-reference-errors-when-compil.patch is there is mistake ? :

+#   define EPIPE_BUGFIX 1
+#endif /* __ALSA_THREADED_VERSION__ */

Sould it be like that :

+#   define EPIPE_BUGFIX 1
+#endif /* __ALSA_EPIPE_BUGFIX__*/


Thanks for helping. I still don't manage to make linphone work without echoes or disto but it's going in a good way. :)

I'll keep you informed. Thomas.

Le 09/02/2018 à 13:29, bagamarco . a écrit :
Hey folks,

working with my iMX6 SoloX and mediastreamer tool I run into some audio problems.
Attached you can find some patches that fix few bugs, simplify alsa filter configuration (threaded version and epipe bug fixing) and other minor changes like typos or compile warning.

In next mails I will provide some general modification and new features to mediastreamer tool.

*Patch list and description:*

    alsa_read_process function in non threaded version read 16ms samples instead of 20ms like other functions.

    Use ENABLE_ALSA_THREADED cmake option to enable alsa threaded version.
    Also fix compile errors in this configuration.

    Use ENABLE_ALSA_EPIPE_BUGFIX cmake option to enable EPIPE_BUGFIX in alsa filter.
    Also fix compile errors in this configuration.

    Actually, when snd_pcm_writei returns EAGAIN, these samples are discarded generating audio noise.
    Increase output buffer size in /etc/asound.conf avoid EAGAIN error.
    In order to simply debug, this patch add ms_debug message every time EAGAIN is returned.
    When an MSAudioMixer input pin is disabled do not consider channel activity and discard samples.

    Added debug information when MSAudioMixer enters into bypass mode.
    Fixed typos

    MSFilePlayer generate strange duplicated audio.
    After some debug, I notice that ms_bufferizer provides duplicated samples.
    This patch added mutex in order protect critical section in msqueue proceducer/consumer.

    I had some problem with OPUS codec. It introduce noise when use PLC.
    Using concealement only when we are late... 
    Minor. Fix warning
    In src/audiostream.c there is a memleak when recorder is stopped.
    With this patch record_file is freed, but the sequece
    is mandatory.

Linphone-developers mailing list

Thomas Dalmayrac
Ingénieur Développement - IHM
3 rue de Bavière
44240 La chapelle sur Erdre
Tel : (+33) 2 51 13 54 66

Attachment: 0003-audiofilters-alsa-fixed-reference-errors-when-compil.patch
Description: Text Data

reply via email to

[Prev in Thread] Current Thread [Next in Thread]