[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Linphone-developers] [bctoolbox] [belle-sip] compilation failure be
From: |
Andrey Gursky |
Subject: |
Re: [Linphone-developers] [bctoolbox] [belle-sip] compilation failure because of API change |
Date: |
Sun, 12 Feb 2017 00:41:30 +0100 |
Hi Sergej,
On Thu, 08 Dec 2016 17:32:16 +0300 Sergej Pupykin wrote:
>
> Hello all,
>
> bctoolbox 0.4.0 changed API, so belle-sip is broken.
>
> I need to patch it to compile against bctoolbox 0.4.0.
>
> ***
> sed -i \
> -e 's|bctbx_list_delete_link|bctbx_list_erase_link|g' \
> -e 's|bctbx_list_remove_link|bctbx_list_unlink|g' \
> include/belle-sip/list.h
> sed -i 's|, super->base.peer_cname ? super->base.peer_cname :
> super->base.peer_name ||' src/transports/tls_channel.c
> ***
>
> Is bctoolbox API unstable or it was mistake that it was changed
> without soname bump?
Good question! And this has been asked [1] (also without feedback).
Looking at bctoolbox, the API has been changed on 22.09.2016 [2] and
included in 0.4.0 release (06.10.2016).
The fix in belle-sip was applied at the same day [3]. But belle-sip
has not been released since 1.5.0 (08.08.2016).
So I'm also wondering what this bctoolbox release with a minor change
in API (that could not be postponed afterwards) is good for, if its
main usage by belle-sip is broken.
It seems the other libraries (bzrtp, ortp and mediastreamer), using
bctoolbox, had more luck?
Regards,
Andrey
[1]
https://github.com/BelledonneCommunications/bctoolbox/commit/dd095f5c12af3f78905eaeb15a4e91098e8d856f#commitcomment-20104624
[2]
https://github.com/BelledonneCommunications/bctoolbox/commit/dd095f5c12af3f78905eaeb15a4e91098e8d856f
[3]
https://github.com/BelledonneCommunications/belle-sip/commit/990ab5fa309cb312a9ef2cd1a84bc2738e14475d
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [Linphone-developers] [bctoolbox] [belle-sip] compilation failure because of API change,
Andrey Gursky <=