[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Linphone-developers] mediastreamer address@hidden

From: Henrik Pauli
Subject: Re: [Linphone-developers] mediastreamer address@hidden
Date: Wed, 15 Apr 2015 17:30:07 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0

Has anyone had time to look at this one yet? :)

On 26/03/15 12:26, Henrik Pauli wrote:
Here's the relevant (not build-system-related) bits of the mediastreamer patch, if you could take a look at it :)

It makes use of shlwapi to manage file paths, which appears to be standard at least as far back as Windows XP. Rather used that than to mess with strings in C (we all know how much fun that is :D)

The patch makes the statement "Linphone looks for the plugins in its installation directory" true, independent of the current working directory. It might have broken some other situations, I'm not sure through all those ifdefs. I assumed that mediastreamer plugins should be located in %installdir%\lib\mediastreamer\plugins, where %installdir%\bin contains the linphone executables. Running linphonecsh.exe from anywhere seems to make linphoned locate the plugins correctly.

On 25/03/15 19:27, Henrik Pauli wrote:
I fixed this and cleaned up a few nasties in terms of wchar_t handling, wouldn't say it's the best code ever but I never code in C if I can help it. Kept all the ifdef unicode things in there (might even work when ifndef unicode but I have no such platform), but since the wchar_t string functions are in since Win95, I made wide chars default, and try to only do wcstombs if I need to interface with a *A winapi call.

Might open a pull request or something about it.

On 25/03/15 13:46, Henrik Pauli wrote:
And finally, a question: mediastreamer seems to locate its plugins relative to the current working directory (in my mingw built linphone anyway), although it claims to be relative to the installation directory. Can you look at the code and tell me whether this is indeed correct?

reply via email to

[Prev in Thread] Current Thread [Next in Thread]