[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Linphone-developers] linphonec.c handle_configfile_migration and a

From: Ghislain MARY
Subject: Re: [Linphone-developers] linphonec.c handle_configfile_migration and a few other weird ifdefs
Date: Thu, 26 Mar 2015 10:03:05 +0100
User-agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0

Hi Henrik,

Thank you very much for pointing out these issues.
I commited fixes for the linphonec.c handle_configfile_migration weird ifdefs and for the WINAPI_FAMILY_PARTITION redefinition stuffs. We are not building linphone with MinGW64 ourselves therefore have not come to this issue yet, but it should now be fixed. Regarding the comment you talk about, there is no conflict. The comment explains exactly what is happening. We are not using the gettext macros (such as AM_GNU_GETTEXT) when mingw_found is yes. By the way, when build with MinGW we are in fact building within an msys environment.


Le 25/03/2015 13:46, Henrik Pauli a écrit :
In 3.8.0, are you sure you mean this in linphonec.c handle_configfile_migration?

#if !defined(_WIN32_WCE)
    char *old_cfg_gui;
    char *old_cfg_cli;
    char *new_cfg;
#if !defined(_WIN32_WCE)
    const char *home = getenv("HOME");
    const char *home = ".";
#endif /*_WIN32_WCE*/
// ... etc etc ...
#endif /*_WIN32_WCE*/

Similarly, it also appears to me that oRTP's port.h has this (and belle-sip's port.h too)

#if defined(__MINGW32__) || !defined(WINAPI_FAMILY_PARTITION)
// Only use with x being WINAPI_PARTITION_DESKTOP to test if building on desktop

Which is wrong because if it is defined already (and it is on recent mingw64), it will be redefined, resulting in a warning, which by default errors out during compilation.

In linphone's and mediastreamer's you have a strange conflict between the code and the comment

if test "$mingw_found" != "yes" ; then
dnl gettext macro does not work properly under mingw. And we want to use the one provided by GTK.

The code starts to work if you change it to "$mingw_found" = "yes" instead. Makes sense too, because the else branch (in mediastreamer at least) contains a -L/usr/lib which does not make much sense in mingw (it may make sense in msys, but not in mingw proper). Or maybe this change would break linux builds (haven't tried), but it certainly fixed mingw for me.

And finally, a question: mediastreamer seems to locate its plugins relative to the current working directory (in my mingw built linphone anyway), although it claims to be relative to the installation directory. Can you look at the code and tell me whether this is indeed correct? I also don't seem ms_set_plugins_dir used anywhere, though it would be pretty cool to be able to specify it from linphonec command line for example.

Linphone-developers mailing list

reply via email to

[Prev in Thread] Current Thread [Next in Thread]