[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Linphone-developers] bug in linphone_core_lookup_known_proxy

From: Ghislain MARY
Subject: Re: [Linphone-developers] bug in linphone_core_lookup_known_proxy
Date: Fri, 21 Mar 2014 17:37:27 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Icedove/24.3.0


Thanks for the bug report. We already found this issue and it should have been fixed yesterday by commit 67faeff9a8c2031c0ff27e6b13227fc05653b85f.

We'll check for the possible orphan code.


On 21/03/2014 17:30, Eli Burke wrote:
I believe that some of the recent changes to add user registration introduced a bug in linphonecore.c : linphone_core_lookup_known_proxy() 

Of course, bug is in the eye of the beholder; maybe the new way is “as intended”, so I didn’t create a patch.

At any rate:  commit f5db8bf on March 3rd removed the line
else found_cfg=default_cfg;

As a result, if no proxy is found with a matching domain name, a NULL proxy is returned. The old behavior would always fall back on the default proxy, and could be restored with:
else if (!found_cfg) found_cfg = default_cfg;

There is another inconsequential bug in linphonecore.c : linphone_core_invite_address_with_params() on line 2787:


“proxy” is set and then overwritten without being used. I suspect the call to linphone_core_get_default_proxy()  is orphan code that can be removed.


Linphone-developers mailing list

reply via email to

[Prev in Thread] Current Thread [Next in Thread]