[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Linphone-developers] linphone 3.6.1 mediastreamer2/src/voip/ice.c

From: Henrik Pauli
Subject: [Linphone-developers] linphone 3.6.1 mediastreamer2/src/voip/ice.c
Date: Tue, 29 Oct 2013 15:14:33 +0100
User-agent: Mozilla/5.0 (X11; Linux i686; rv:24.0) Gecko/20100101 Thunderbird/24.0.1

I ran into -Werror=formats complaining about the source of ice.c (running mingw/msys+GCC on Windows XP).

Around line 190, we have three functions, generate_tie_breaker, generate_ufrag and generate_pwd. The first one casts the calls to random() to uint64_t, the other two don't. Those break because the %lx format expects long unsigned int, and random returns int. Might be a good idea to say (long unsigned int)random() in all four places.

Not entirely sure, I'm not a C programmer.  What do you think?

reply via email to

[Prev in Thread] Current Thread [Next in Thread]