[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Linphone-developers] Contributing to linphone

From: Valentin Beraudo
Subject: Re: [Linphone-developers] Contributing to linphone
Date: Thu, 01 Sep 2011 18:50:05 +0200
User-agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:6.0.1) Gecko/20110830 Thunderbird/6.0.1

I moved notify_uninit() to the end of main(), which is indeed a better place for it, as the core is no longer active.

Also changed the tone for a 400Hz, 300ms duration, 8s silence one. Sounds indeed more "waiting tone"-like.


ps : fixed patch for linphone attached

Le 30/08/2011 22:07, Simon Morlat a écrit :
Ok looks much better !

I have a few other remarks:
1) why did call notify_uninit() in linphone_gtk_close() ? Because linphone_gtk_close() is called when the user dismisses the main window, not when linphone leaves. Don't you think the end of main() would be a better place for notify_uninit() ?

2) Regarding the tone to indicate an incoming call, I have found that this kind of tone is actually normalized by ITU-T E180. Here is an extract:

Call waiting tone
The call waiting tone is used to advise a subscriber who is engaged on a call that another subscriber is
attempting to call.
The tone is intended to be sufficiently alerting to succeed in its purpose without interfering with existing
The recommend specification of the tone is one or more cycles defined by a frequency f in the range:
f : 400 to 450 Hz
and with a cadence (frequency sequence) as follows:
a) f on 300 to 500 ms, silence 8 to 10 s (f = 300 ms is preferable to the longer tone since the ongoing conversation
  would be interrupted for a briefer interval); or
b) f on 100 to 200 ms, silence 100 to 200 ms, f on 100 to 200 ms (the total to be no more than 500 ms); 8 to 10 s
Other tones may be acceptable.
The second and subsequent cycles may be at a lower level than the initial one.
Where the tone continues for more than one cycle, it should preferably cease when it is no longer possible to
accept the waiting call.


As you see it is not a dtmf (dual tone) but a single tone that repeats every 8-10 seconds. Could you modify the tone settings to reflect this specification ?

Otherwise I will do it, just tell me if you are lacking time.



Attachment: dtmf-tones_notif_lin_fixed.patch
Description: Text document

reply via email to

[Prev in Thread] Current Thread [Next in Thread]