[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Linphone-developers] Mediastreamer as external project with --enabl

From: Simon Brenner
Subject: Re: [Linphone-developers] Mediastreamer as external project with --enable-external-mediastreamer?
Date: Mon, 27 Sep 2010 17:39:18 +0200
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv: Gecko/20100908 Thunderbird/3.1.3


once again I'm sending a patch file with some proposals to change.
- I had to remove the paragraphs for MS2_DIR and ORTP_DIR: this is to make 
'make dist' work.
  With the current state 'make dist' pretends to 'cd' into 'mediastreamer2' and 
'oRTP' and archive
  them also.
- Had to remove AM_PROG_LIBTOOL: there is already a call to 'AC_PROG_LIBTOOL'.
- I changed the default behaviour of --enable-external-mediastreamer and 
--enable-external-ortp to
  "yes". This is perhaps a major change but has to be done in order to get 
"make distcheck" working.
  If you build 'linphone' with the 'mediastreamer2' and 'oRTP' submodules you 
have now to configure
  your build with '--disable-external-mediastreamer' and 
- I don't know why there were still some mediastreamer source files references 
there, I removed
  them to suppress errors.

- Added the mediastreamer files to avoid errors from 'make distcheck'.
- fix a problem when srcdir='.'.

console/linphonec.c, coreapi/sal_eXosip2_presence.c
- Cosmetic changes to some template strings to avoid 'make distcheck' errors.

Now, everything seems to be alright! "make dist" and "make distcheck" also run.
The attached patch was generated against a linphone git repository with commit 



On 09/25/2010 05:44 PM, Simon Morlat wrote:
> I merged it, thanks.
> I had to rework it because it broke the default behaviour with various
> errors and "make distcheck" failed.
> I hope my fixes didn't break the "external" mode, let me know
> otherwise !
> Simon
> Le mercredi 22 septembre 2010 à 17:02 +0200, Simon Brenner a écrit :
>> Hi Simon,
>> ok, I created a patch file with all the things I consider worth doing to 
>> prepare this thing. Please
>> have a careful look at everything and include it into mainline if you want 
>> to.
>> I created and tested my patch with a Linphone from git with the commit id
>> 8210107a35463f30894027ad271ee0f66d79cb00 (22.09.2010).
>> Regards,
>> -Simon
>> On 09/17/2010 09:28 AM, Simon Morlat wrote:
>>> Hi Simon,
>>> There is no reason not to include this patch in mainline. This is of
>>> interest for people packaging linphone, mediastreamer2 and oRTP in linux
>>> distros.
>>> Please send it and I'll merge it to master branch.
>>> Simon
>>> Le lundi 06 septembre 2010 à 12:00 +0200, Simon Brenner a écrit :
>>>> Hi,
>>>> the current linphone configure script offers the option 
>>>> '--enable-external-ortp' so that it is
>>>> possible to build/install the ortp package independently from the 
>>>> 'linphone' one and make 'linphone'
>>>> use the installed 'ortp' instead of the ortp subproject within the 
>>>> linphone git repository.
>>>> I was wondering whether the same is possible with the 'mediastreamer2' 
>>>> project.
>>>> Looking, for example, at the coreapi/ I see a hard-coded 
>>>> include path for mediastreamer2
>>>> and linker path:
>>>> INCLUDES = \
>>>>    -I$(top_srcdir)\
>>>>    -I$(top_srcdir)/mediastreamer2/include
>>>> liblinphone_la_LIBADD= \
>>>>            $(EXOSIP_LIBS) \
>>>>            $(top_builddir)/mediastreamer2/src/ \
>>>>            $(ORTP_LIBS)
>>>> I actually tried myself to add a '--enable-external-mediastreamer' option 
>>>> to the and
>>>> replaced these hard-coded paths with the two variables 
>>>> 'MEDIASTREAMER_LIBS' and it actually worked as expected.
>>>> Are there specific reasons not to include this in mainline?
>>>> Thanks,
>>>> -Simon.

Attachment: patch0.patch
Description: Text document

reply via email to

[Prev in Thread] Current Thread [Next in Thread]