[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Linphone-developers] Two bugs in Linphone 3.0.0, one (apparent) fix
From: |
Jim Diamond |
Subject: |
[Linphone-developers] Two bugs in Linphone 3.0.0, one (apparent) fix |
Date: |
Sun, 1 Mar 2009 12:20:01 -0400 |
User-agent: |
Mutt/1.5.18 (2008-05-17) |
Hi,
(1) in gtk-glade/main.c, there is the code
void linphone_gtk_decline_call(GtkWidget * button)
{
linphone_core_terminate_call(linphone_gtk_get_core(), NULL);
linphone_gtk_call_terminated(gtk_widget_get_toplevel(button));
gtk_widget_destroy(gtk_widget_get_toplevel(button));
}
When someone calls, and you click the "Decline" button, the
linphone_gtk_call_terminated(gtk_widget_get_toplevel(button));
statement causes an abort. (I'm guessing that no linphone developer
user ever declines a call; could this be true???)
Commenting out this statement seems to work for me with no ill effects.
(2) in coreapi/linphonecore.c there is the code
static void linphone_core_disconnected(LinphoneCore * lc)
{
lc->vtable.display_warning(lc, _("Remote end seems to have disconnected,
the call is going to be closed."));
linphone_core_terminate_call(lc, NULL);
}
There is a shortcoming here in that there is nothing to tell the GUI
to change the "Terminate call" button back to "Start call".
I think (maybe) we want something along the lines of
linphone_gtk_call_terminated(gtk_widget_get_toplevel(button));
to be called there, but of course it is not that simple.
I have not yet come to understand the code well enough to know the
Right Way to do this. I considered adding another entry to the vtable,
and testing for / calling it from linphone_core_disconnected(), but
I'm not sure if that is The Right Way To Do It or not.
Comments/suggestions?
Thanks.
Jim
- [Linphone-developers] Two bugs in Linphone 3.0.0, one (apparent) fix,
Jim Diamond <=