[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Linphone-developers] Purpose of linphone-1.99.0

From: Francois-Xavier KOWALSKI
Subject: Re: [Linphone-developers] Purpose of linphone-1.99.0
Date: Thu, 01 Nov 2007 11:39:20 +0100
User-agent: Thunderbird (X11/20070728)

address@hidden wrote:
On Wed, Oct 31, 2007 at 03:31:30PM +0100, Francois-Xavier KOWALSKI wrote:
address@hidden wrote:
I've compiled unstable/linphone-1.99.0 after some problems. I've met three

1) mediastreamer2/src/gsm.c includes <gsm/gsm.h> while -L../../libgsm.
leads into "gsm/gsm.h not found". Are you moving to external gsm library?
This patch fixes it:

diff -Naur linphone-1.99.0-org/mediastreamer2/src/gsm.c
--- linphone-1.99.0-org/mediastreamer2/src/gsm.c    2007-06-27
10:36:47.000000000 +0200
+++ linphone-1.99.0/mediastreamer2/src/gsm.c    2007-10-28
22:59:33.000000000 +0100
@@ -19,7 +19,7 @@

 #include "mediastreamer2/msfilter.h"

-#include <gsm/gsm.h>
+#include <gsm.h>

This one will break gsm support on Fedora/RedHat:

% rpm -ql gsm-devel

linphone containts its own libgsm under libgsm. If you investigate
in mediastreamer2, you can see that library used for linking is library
from linphone. Therefore if you have installed gsm-devel, header files are
taken from /usr/include, but object file from linphone/libgsm. This is bad and
should be fixed. Linphone should use header and object files from one location
at one time.

We can remove libgsm subdir from linphone's sources, create explicit check
in for gsm-config and change mediastreamer2/ to use
system wide libgsm. (This is my favourite option.)

I was not aware that linphone was hosting a private version of libgsm. Your point is absolutely correct that the result is likely to be more broken with mix-up rather than with built-in.

Or we can use my patch (How does it break your system exactly? I have no
system wide libgsm installed) to use internal implemetation only.

Simply because built-in libgsm is probably addressed by -I$(top_srcdir)/gsmlib hand hence does not contain the intermediate "gsm/" subdir.

Finaly we can make the location of libgsm library and header files compile
time configurable via configure parameter.

How do you vote?

Given that auto-tools kind of build does not come upstream with the gsm package (each distro provides its own one), I'd vote for keeping the gsmlib code into linphone.


Francois-Xavier "FiX" KOWALSKI     /_ __        Tel:+33 (0)4 76 14 63 27
HP OpenCall Software  - EMTS      / //_/        Fax:+33 (0)4 76 14 51 62
Media-Processing Engineering        /
                              i n v e n t

reply via email to

[Prev in Thread] Current Thread [Next in Thread]