[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
broken bracket pedal
From: |
Han-Wen Nienhuys |
Subject: |
broken bracket pedal |
Date: |
Sat, 20 Dec 2003 12:42:09 +0100 |
address@hidden writes:
> Attached is a small example broken bracket pedal. It seems that the
> extra width added by the arpeggio breaks the horizontal spacing of
> bracket pedal. I guess it's closely related to what was reported by
> Jonathan Kraut on 12/12-2003. Did you (Jonathan) file a bug report?
try this.
diff -purN ../lilypond-2.1.0/lily/piano-pedal-engraver.cc
./lily/piano-pedal-engraver.cc
--- ../lilypond-2.1.0/lily/piano-pedal-engraver.cc 2003-07-23
19:48:28.000000000 +0200
+++ ./lily/piano-pedal-engraver.cc 2003-12-16 00:42:02.000000000 +0100
@@ -144,7 +144,6 @@ Piano_pedal_engraver::acknowledge_grob (
if (p->line_spanner_)
{
Side_position_interface::add_support (p->line_spanner_,
info.grob_);
-
add_bound_item (p->line_spanner_,info.grob_);
}
if (p->bracket_)
@@ -404,10 +403,22 @@ Piano_pedal_engraver::create_bracket_gro
p->bracket_->set_grob_property ("pedal-text", p->item_->self_scm
());
}
- p->bracket_->set_bound (LEFT, unsmob_grob (get_property
("currentMusicalColumn")));
- Axis_group_interface::add_element (p->line_spanner_, p->bracket_);
- add_bound_item (p->line_spanner_, p->bracket_->get_bound (LEFT));
+ /*
+ We do not use currentMusicalColumn for the left span-point.
+ If the column as accidentals (eg on a different stave), the
+ currentMusicalColumn is too wide, making the bracket too big.
+
+ TODO:
+
+ Hmm. What do we do when there are no notes when the spanner starts?
+
+ TODO:
+
+ what about the right span point?
+
+ */
+ Axis_group_interface::add_element (p->line_spanner_, p->bracket_);
announce_grob (p->bracket_, p->event_drul_[START]->self_scm ());
if (!p->event_drul_[STOP])
--
Han-Wen Nienhuys | address@hidden | http://www.xs4all.nl/~hanwen