[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Adding scheme interfaces without using them?

From: David Kastrup
Subject: Re: Adding scheme interfaces without using them?
Date: Sat, 25 Jun 2022 22:53:49 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux)

Lukas-Fabian Moser <> writes:

> Folks,
> is it acceptable to submit a MR that adds a scheme interface to some
> C++ routine without using that new interface in LilyPond proper?
> In my case, I made Bezier::solve_point Scheme-visible for some work
> project of mine that is too spezialized to submit as a MR (at least
> for the time being). But without the addition of ly:bezier-solve-point
> in Scheme, I can only ever engrave my work project with a
> custom-compiled LilyPond differing from Master.

Well, you should at least add examples in the form of regtests, and in
case of something like Bezier::solve_point it would make sense to take
stock of what there is on the C++ side and see whether
Bezier::solve_point would make sense as an integral part of a larger
whole that gives a convenient toolbox in connection with other
Bezier-related functionality, and then plot what that whole should

Basically try to aim for something making sense as a whole and not just
for supporting your particular application that is so specialised that
it does not make sense as a MR.

David Kastrup

reply via email to

[Prev in Thread] Current Thread [Next in Thread]