lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: repository at GitLab


From: Jonas Hahnfeld
Subject: Re: repository at GitLab
Date: Mon, 11 May 2020 15:29:40 +0200
User-agent: Evolution 3.36.2

Am Montag, den 11.05.2020, 15:00 +0200 schrieb David Kastrup:
> Jonas Hahnfeld <address@hidden> writes:
> > Am Montag, den 11.05.2020, 14:54 +0200 schrieb David Kastrup:
> > > Jonas Hahnfeld <address@hidden> writes:
> > > > Yes, I think pushing existing reviews as a merge request is the easiest
> > > > solution. For the beginning we could of course also live with a mixture
> > > > of (old-style) issues and merge requests, but the countdown script I
> > > > wrote for James only considers merge requests. So pushing as a branch
> > > > and adding the previous label to the MR would be great.
> > > > 
> > > > For merging I would not use the UI yet but manually push to staging as
> > > > before. So targeting 'master' by default for now shouldn't be a
> > > > problem.
> > > 
> > > It turns out that issues have above the discussion a menu entry to open
> > > a merge request.  I have not found an obvious way to link a merge
> > > request created independently to an issue.
> > 
> > This will create a branch starting with issue number, no big magic
> > though.
> > 
> > > So instead of pushing independently as a merge request (unless the merge
> > > request is of the common form of stating and solving a problem or task
> > > at the same time), it seems to be the right way to open the merge
> > > request in the existing issue and go from there.
> > > 
> > > I'll try doing that in parallel now, and possibly decide to kill the
> > > independent merge request if that works.
> > 
> > Instead you may put a "Closes #<num>" into the last of your commits.
> > This will automatically link the MR and even close the issue once the
> > commits hit master.
> 
> It would appear that the merge request now is listed as "linked" in the
> issue, possibly because of a comment I posted referencing it.
> 
> Issue numbers are recognised with #<num> syntax in general?

Yes, here's the full list of references:
https://docs.gitlab.com/ee/user/markdown.html#special-gitlab-references

For us, issues (#<num>) and MRs (!<num>) are likely the most important.

Jonas

Attachment: signature.asc
Description: This is a digitally signed message part


reply via email to

[Prev in Thread] Current Thread [Next in Thread]