[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Add OTC font support for `-dfont-ps-resdir` (issue 548080043 by addr
|
From: |
trueroad |
|
Subject: |
Re: Add OTC font support for `-dfont-ps-resdir` (issue 548080043 by address@hidden) |
|
Date: |
Sun, 03 May 2020 22:45:22 -0700 |
Thank you for your reviewing.
https://codereview.appspot.com/548080043/diff/567530058/lily/open-type-font-scheme.cc
File lily/open-type-font-scheme.cc (right):
https://codereview.appspot.com/548080043/diff/567530058/lily/open-type-font-scheme.cc#newcode467
lily/open-type-font-scheme.cc:467: warning (_f ("font index %d too large
for font `%s', using index 0",
On 2020/05/04 04:33:59, lemzwerg wrote:
> Maybe it makes sense to use a format like
>
> font `%s': ...
>
> here, too.
Done.
https://codereview.appspot.com/548080043/diff/567530058/lily/open-type-font-scheme.cc#newcode495
lily/open-type-font-scheme.cc:495: warning (_f ("font `%s': cannot read
`%s' field of subfont %d",
On 2020/05/04 04:33:59, lemzwerg wrote:
> Shall we do
>
> s/`%s' field/field `%s'/
>
> here and in the following messages? Ditto
>
> s/`%s' table/table `%s'/
>
> later on. We already have `font xxx' and `subfont yyy'...
Done.
https://codereview.appspot.com/548080043/diff/567530058/lily/open-type-font-scheme.cc#newcode513
lily/open-type-font-scheme.cc:513: warning (_f ("font `%s': cannot open
for writing",
On 2020/05/04 04:33:59, lemzwerg wrote:
> Shall we replace `font' with `subfont' here and in succeeding write
messages?
Done.
https://codereview.appspot.com/548080043/diff/567530058/lily/open-type-font-scheme.cc#newcode594
lily/open-type-font-scheme.cc:594: " table no. %u of subfont %d",
On 2020/05/04 04:33:59, lemzwerg wrote:
> s/table no. %u/table %u/
Done.
https://codereview.appspot.com/548080043/