Re: Added transition lines for lyrics (issue 565750043 by address@hidden)

[hanwenn]

LGTM

Can you verify that the patch description is correct? The current
version doesn't use -> anymore.


https://codereview.appspot.com/565750043/diff/569570043/lily/vowel-transition.cc
File lily/vowel-transition.cc (right):

https://codereview.appspot.com/565750043/diff/569570043/lily/vowel-transition.cc#newcode37
lily/vowel-transition.cc:37: SCM num_length = me->get_property
("minimum-length");
num suggests a number.

minimum_length ?

https://codereview.appspot.com/565750043/diff/569570043/lily/vowel-transition.cc#newcode137
lily/vowel-transition.cc:137: w += -d * r->item_drul_[d]->extent
(r->item_drul_[d], X_AXIS)[-d];
this still looks strange, but if it's problem, it'll be contained within
the vowel-transition code, which is acceptable.

https://codereview.appspot.com/565750043/