lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Cleanup flower/ makefile (issue 577700045 by address@hidden)


From: lemzwerg
Subject: Cleanup flower/ makefile (issue 577700045 by address@hidden)
Date: Sat, 21 Mar 2020 23:13:20 -0700

LGTM, with nits.


https://codereview.appspot.com/577700045/diff/547810068/flower/GNUmakefile
File flower/GNUmakefile (right):

https://codereview.appspot.com/577700045/diff/547810068/flower/GNUmakefile#newcode17
flower/GNUmakefile:17: TEST_LOADLIBES = $(LIBRARY) $(CXXABI_LIBS)
I suggest s/TEST_LOADLIBES/TEST_LOADLIBS/.

https://codereview.appspot.com/577700045/diff/547810068/flower/GNUmakefile#newcode33
flower/GNUmakefile:33: AR=ar
s/AR=ar/AR = ar/ for consistency.

Irrespective of that I wonder why setting `AR` is necessary at all since
the configure script sets this variable (via the `STEPMAKE_LIB` macro) –
it seems to make that it won't work with cross-compiling.

https://codereview.appspot.com/577700045/



reply via email to

[Prev in Thread] Current Thread [Next in Thread]