[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: flower: Get rid of libc-extension (issue 553740043 by address@hidden
From: |
lemzwerg |
Subject: |
Re: flower: Get rid of libc-extension (issue 553740043 by address@hidden) |
Date: |
Tue, 17 Mar 2020 14:28:34 -0700 |
https://codereview.appspot.com/553740043/diff/547780043/input/regression/tie-single-manual.ly
File input/regression/tie-single-manual.ly (right):
https://codereview.appspot.com/553740043/diff/547780043/input/regression/tie-single-manual.ly#newcode19
input/regression/tie-single-manual.ly:19: \override Tie.staff-position =
#-7.4
> I'm not really happy about tweaking this test like this.
> It relies on rounding halfway always up (my_round)
> instead of away from zero (std::round). I think this is
> a coincidence, but if we want to retain this I need to
> go through all replacements of my_round -> std::round
> and check if the argument could be negative...
Hmm. Are you talking about rounding to integers? If `staff-position`
is a floating point value, LilyPond takes it as an exact value, see
`has_manual_delta_y`. So there shouldn't be any rounding here...
I've accidentally added this to the documentation today, see issue
#4955.
https://codereview.appspot.com/553740043/