Re: Remove compat hack for Solaris7 and HP-UX (issue 579480047 by address@hidden)

[hanwenn]

On 2020/03/15 16:47:55, dak wrote:
> https://codereview.appspot.com/579480047/diff/547750043/aclocal.m4
> File aclocal.m4 (right):
> 
>
https://codereview.appspot.com/579480047/diff/547750043/aclocal.m4#newcode694
> aclocal.m4:694: AC_PATH_PROG(BASH, bash, $SHELL)
> This sets BASH with a fallback to /bin/sh , meaning that $BASH is not
guaranteed
> to be anything remotely likely to Bash.
> 
> And in the current code base, it would not appear that $BASH is even
getting
> used anywhere.  At least I cannot find anything suggesting its use 
(rather than
> its maintenance) with
> 
> git grep BASH origin
> 
> So what is supposed to be the idea with $BASH here?  What is it
supposed to
> guarantee providing, and where is it supposed to (eventually?) get
used?

I removed all things BASH for now.

We might want to consider hardcoding all our shell scripts to /bin/bash,
though.

https://codereview.appspot.com/579480047/