|
From: | jonas . hahnfeld |
Subject: | Re: Address output-distance problems: (issue 563730043 by address@hidden) |
Date: | Wed, 11 Mar 2020 05:15:54 -0700 |
Looks mostly good to me, but I don't understand the change for <meta>. I'd propose to push only the changes required to restore 'make check' because it's blocking James from testing patches. https://codereview.appspot.com/563730043/diff/577660046/scripts/build/output-distance.py File scripts/build/output-distance.py (right): https://codereview.appspot.com/563730043/diff/577660046/scripts/build/output-distance.py#newcode834 scripts/build/output-distance.py:834: <meta http-equiv="Content-Type" content="text/html; charset=utf-8"> I don't understand this change, see https://stackoverflow.com/a/4696517/10606944 https://codereview.appspot.com/563730043/
[Prev in Thread] | Current Thread | [Next in Thread] |