[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: output-distance: treat non-existent files as empty string (issue 583
|
From: |
nine . fierce . ballads |
|
Subject: |
Re: output-distance: treat non-existent files as empty string (issue 583590043 by address@hidden) |
|
Date: |
Fri, 06 Mar 2020 17:02:47 -0800 |
On 2020/03/06 16:28:01, hanwenn wrote:
>
>
https://codereview.appspot.com/581770043/diff/561510043/scripts/build/output-distance.py
>
> it leaves striped cells for removed files. I don't think it's feasible
to do
> much better, or we'd have to extend output-distance to infer what kind
of files
> are to be expected. That will likely be brittle logic.
I haven't looked at the code yet, but I think this treatment is
acceptable.
--
Dan
https://codereview.appspot.com/583590043/