|
From: | dak |
Subject: | Re: Don't count terminating \0 in Source_file::length (issue 579310043 by address@hidden) |
Date: | Fri, 14 Feb 2020 14:40:51 -0800 |
https://codereview.appspot.com/579310043/diff/561450043/lily/source-file.cc File lily/source-file.cc (right): https://codereview.appspot.com/579310043/diff/561450043/lily/source-file.cc#newcode137 lily/source-file.cc:137: data_ = string (&chars[0], chars.size ()); gulp_file_to_string ? That one apparently also does some kind of logging, so one should check that using it does not lead to duplications in the log. https://codereview.appspot.com/579310043/
[Prev in Thread] | Current Thread | [Next in Thread] |