lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Replace deprecated functions from string module (issue 566920044 by


From: dak
Subject: Re: Replace deprecated functions from string module (issue 566920044 by address@hidden)
Date: Sat, 11 Jan 2020 17:13:51 -0800


https://codereview.appspot.com/566920044/diff/549120043/python/convertrules.py
File python/convertrules.py (right):

https://codereview.appspot.com/566920044/diff/549120043/python/convertrules.py#newcode3898
python/convertrules.py:3898: mods = str.join (re.findall ("\n(" +
wordsyntax + r")\s*=\s*\\with(?:\s|\\|\{)")
  File
"/usr/local/tmp/lilypond/out/lib/lilypond/current/python/convertrules.py",
line 3892, in conv
    mods = str.join (re.findall ("\n(" + wordsyntax +
r")\s*=\s*\\with(?:\s|\\|\{)")
TypeError: findall() takes at least 2 arguments (1 given)

I'd call that a case of insufficient testing...  Sometimes our tests
don't cover everything and one has to check out things on one's own.

https://codereview.appspot.com/566920044/



reply via email to

[Prev in Thread] Current Thread [Next in Thread]