Re: Chord names clean-up; no more Banter, exceptionsPartial or \powerChords

[Flaming Hakama by Elaine]

> ---------- Forwarded message ----------
> From: address@hidden
> To: address@hidden
> Cc: address@hidden, address@hidden
> Date: Tue, 07 Jan 2020 14:06:51 -0800
> Subject: Re: Chord names clean-up; no more Banter, exceptionsPartial or
> \powerChords. (issue 363880043 by address@hidden)
>
> https://codereview.appspot.com/363880043/diff/80001/python/convertrules.py
> File python/convertrules.py (right):
>
>
> https://codereview.appspot.com/363880043/diff/80001/python/convertrules.py#newcode3980
> python/convertrules.py:3980
> <https://codereview.appspot.com/363880043/diff/80001/python/convertrules.py#newcode3980python/convertrules.py:3980>:
> if re.search
> (r"#[banter|jazz]-chord-names", str):
> I have no idea what this regexp is actually supposed to be/do.  But it
> needs to get fixed.  Any idea what this should be instead?
>
> As it is, it matches a # followed by one of the letters abejntrz| and
> then -chord-names .  This is very likely not what is intended here.
>
> https://codereview.appspot.com/363880043/
>

My guess as to the intention is that it should match either
"#banter-chord-names" or "#jazz-chord-names".

Although, it is unclear why those strings are important.

Seems like they just mistakenly used square brackets instead of parenthesis
for grouping in the regular expression.


HTH,

Elaine Alt
415 . 341 .4954                                           "*Confusion is
highly underrated*"
address@hidden
Producer ~ Composer ~ Instrumentalist ~ Educator
-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-