Re: Issue 5628: fix warnings compiling flower unit tests (issue 545320043 by address@hidden)

[dak]

On 2019/12/11 13:55:56, Dan Eble wrote:
> On 2019/12/11 07:17:30, hahnjo wrote:
> > On 2019/12/10 22:28:46, Dan Eble wrote:
> > > I don't know if the compiler that GUB uses properly supports
C++11,
> > > and I'm not yet interested in spending my own time to investigate.
> >
> > GUB builds GCC 4.9.4 which is fine for C++11.

> That depends on your definition of "fine."  I wouldn't want to have my
time
> wasted by something like these, for example:

> [c++11] trivial class fails std::is_trivial test
> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=53036

> [constexpr] bogus diagnostic "used in its own initializer"
> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=59937

Somewhat weirdly, if we are making some standard definite in the calling
options, I'd somehow be happier with C++11.  C++03 seems a bit backward.
 But there's probably no point in upgrading GCC in GUB before we have
retired PowerPC, right?

https://codereview.appspot.com/545320043/