[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Document bound-details (sub-)properties in line-spanner-cc for IR (i
From: |
lemzwerg |
Subject: |
Re: Document bound-details (sub-)properties in line-spanner-cc for IR (issue 560670043 by address@hidden) |
Date: |
Thu, 09 May 2019 22:22:31 -0700 |
LGTM, thanks. Only cosmetic nits :-)
https://codereview.appspot.com/560670043/diff/550690043/lily/line-spanner.cc
File lily/line-spanner.cc (right):
https://codereview.appspot.com/560670043/diff/550690043/lily/line-spanner.cc#newcode395
lily/line-spanner.cc:395: "Sets the Y-coordinate of the end point, in
staff-spaces"
I think this should rather be
Sets the address@hidden, in staff spaces.
Ditto in other places.
https://codereview.appspot.com/560670043/diff/550690043/lily/line-spanner.cc#newcode398
lily/line-spanner.cc:398: " vertical center of the note head.\n"
The final `\n' here (and in similar places) in the middle of a paragraph
doesn't have any effect. texinfo simply slurps it. Only two `\n' in a
row to indicate a paragraph end are honored.
https://codereview.appspot.com/560670043/diff/550690043/lily/line-spanner.cc#newcode404
lily/line-spanner.cc:404: " So, a value of -1 (or LEFT) makes the line
start/end at"
... or @code{LEFT} ...
https://codereview.appspot.com/560670043/diff/550690043/lily/line-spanner.cc#newcode416
lily/line-spanner.cc:416: "@item stencil-offset\n"
@itemx stencil-offset\n
https://codereview.appspot.com/560670043/diff/550690043/lily/line-spanner.cc#newcode418
lily/line-spanner.cc:418: " end-point, centered on the line, as defined
by the X and"
end point, ... by the @code{X} and @code{Y} ...
https://codereview.appspot.com/560670043/diff/550690043/lily/line-spanner.cc#newcode420
lily/line-spanner.cc:420: " stencil-offset will move the symbol at the
edge vertically"
Setting either @code{...} or @code{...}
https://codereview.appspot.com/560670043/
- Document bound-details (sub-)properties in line-spanner-cc for IR (issue 560670043 by address@hidden), thomasmorley65, 2019/05/09
- Re: Document bound-details (sub-)properties in line-spanner-cc for IR (issue 560670043 by address@hidden),
lemzwerg <=
- Re: Document bound-details (sub-)properties in line-spanner-cc for IR (issue 560670043 by address@hidden), dak, 2019/05/10
- Re: Document bound-details (sub-)properties in line-spanner-cc for IR (issue 560670043 by address@hidden), lemzwerg, 2019/05/10
- Re: Document bound-details (sub-)properties in line-spanner-cc for IR (issue 560670043 by address@hidden), thomasmorley65, 2019/05/10
- Re: Document bound-details (sub-)properties in line-spanner-cc for IR (issue 560670043 by address@hidden), lemzwerg, 2019/05/10
- Re: Document bound-details (sub-)properties in line-spanner-cc for IR (issue 560670043 by address@hidden), thomasmorley65, 2019/05/12
- Re: Document bound-details (sub-)properties in line-spanner-cc for IR (issue 560670043 by address@hidden), lemzwerg, 2019/05/12
- Re: Document bound-details (sub-)properties in line-spanner-cc for IR (issue 560670043 by address@hidden), lemzwerg, 2019/05/13
- Re: Document bound-details (sub-)properties in line-spanner-cc for IR (issue 560670043 by address@hidden), thomasmorley65, 2019/05/15
- Re: Document bound-details (sub-)properties in line-spanner-cc for IR (issue 560670043 by address@hidden), thomasmorley65, 2019/05/22