Re: C++ cleanup : get rid of some compilation warnings (issue 353880043 by address@hidden)

[dak]

On 2019/02/19 13:46:56, lemzwerg wrote:
> https://codereview.appspot.com/353880043/diff/2/lily/main.cc
> File lily/main.cc (right):


https://codereview.appspot.com/353880043/diff/2/lily/main.cc#newcode635
> lily/main.cc:635: { }; // ignore option for backwards compatibility
> On 2019/02/19 12:55:10, dak wrote:
> > This code is insane.  Maybe just outcomment the whole else if branch
instead?

> Well, option `--relocate' should (1) be recognized (i.e., it shouldn't
produce
> an error), but at the same time it should (2) be a no-op.  Removing
the branch
> would disable (1)...

Where do you see any action taken differently in reaction to
"recognizing" --relocate?  This just runs into break; either way.

https://codereview.appspot.com/353880043/