[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: sort input files (issue 347770043 by address@hidden)
|
From: |
nine . fierce . ballads |
|
Subject: |
Re: sort input files (issue 347770043 by address@hidden) |
|
Date: |
Fri, 18 May 2018 14:15:39 -0700 |
https://codereview.appspot.com/347770043/diff/1/stepmake/stepmake/c++-vars.make
File stepmake/stepmake/c++-vars.make (right):
https://codereview.appspot.com/347770043/diff/1/stepmake/stepmake/c++-vars.make#newcode14
stepmake/stepmake/c++-vars.make:14: CC_FILES := $(sort $(call
src-wildcard,*.cc))
This seems fragile. If the order of arguments to the linker is what
matters, the call to sort should be in the linker command. For example,
one could break this by adding CC_FILES += $(wildcard another-dir/*.cc)
in an included makefile.
https://codereview.appspot.com/347770043/