Re: Allow quoted strings as Scheme arguments to markup commands (issue 331820043 by address@hidden)

[thomasmorley65]

On 2017/10/06 22:00:07, dak wrote:

https://codereview.appspot.com/331820043/diff/20001/python/convertrules.py
> File python/convertrules.py (right):


https://codereview.appspot.com/331820043/diff/20001/python/convertrules.py#newcode3963
> python/convertrules.py:3963: str = re.sub
> (r'(\\(?:justify-string|musicglyph|harp-pedal|simple|postscript'
> On 2017/10/06 21:37:47, Malte Meyn wrote:
> > Isn’t this list of markup commands with string arguments far from
complete?

> Likely.  It was cooked up on the basis of a git grep call, I think

>      git grep '\\markup.*#"'


> > What
> > about wordwrap-string, eps-file, with-url, lookup, verbatim-file,
> > wordwrap-string-internal, and the accordion commands discant,
freeBass,
> stdBass,
> > stdBassIV, stdBassV, and stdBassVI?

> Some of them certainly are good candidates, as long as their
_first_(!) argument
> is the string argument.  Otherwise, the convert-ly expression becomes
a lot more
> tricky.

One could probably do something at the lines of:
(pretty-print
  (sort
    (map car
      (filter
        (lambda (x)
          (let* ((predicates (markup-command-signature (cdr x))))
            (and predicates
                 (pair? predicates)
               (eq?
                 (procedure-name string?)
                 (car (map procedure-name predicates))))))
        (ly:module->alist (resolve-module '(lily)))))
    symbol<?))

->
 (fret-diagram-markup
  fret-diagram-terse-markup
  harp-pedal-markup
  justify-string-markup
  lookup-markup
  musicglyph-markup
  postscript-markup
  rest-markup
  simple-markup
  tied-lyric-markup
  verbatim-file-markup
  with-url-markup
  wordwrap-string-markup)


https://codereview.appspot.com/331820043/