lilypond-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Use -b together with -dgs-never-embed-fonts (issue 325630043 by addr


From: knupero
Subject: Re: Use -b together with -dgs-never-embed-fonts (issue 325630043 by address@hidden)
Date: Sat, 23 Sep 2017 09:22:58 -0700

Reviewers: dak,

Message:
On 2017/09/23 16:02:32, dak wrote:

https://codereview.appspot.com/325630043/diff/1/make/lilypond-vars.make
File make/lilypond-vars.make (right):


https://codereview.appspot.com/325630043/diff/1/make/lilypond-vars.make#newcode54
make/lilypond-vars.make:54: -dgs-never-embed-fonts -b
Is there a conceivable application for using -b without
-dgs-never-embed-fonts ?
  If not, shouldn't -b imply -dgs-never-embed-fonts anyway ?  Otherwise
people
are likely to get results they don't expect I think.

It definitely is usefull to be able to use -dgs-never-embed-fonts
without -b.

To force -dgs-never-embed-fonts if -b is used will definitely break
existing scripts. Of course, existing scripts will also be broken by new
versions of ghostscript - but not everyone uses gs versions above 9.16,
and it will take a long time until it is save to assume that everybody
uses at least ghostscript 9.22.

I think it's definitely necessary to add some documentation.

I also have to (and I will) test some old versions of ghostscript.


Description:
Use -b together with -dgs-never-embed-fonts

Signed-off-by: Knut Petersen <address@hidden>

Please review this at https://codereview.appspot.com/325630043/

Affected files (+2, -2 lines):
  M make/lilypond-vars.make
  M make/lysdoc-targets.make


Index: make/lilypond-vars.make
diff --git a/make/lilypond-vars.make b/make/lilypond-vars.make
index 1fd163caa174dec5cf62a6fac438266049a219b1..0e1b79583e77abfb3a6221562c23eecfbef4b8e2 100644
--- a/make/lilypond-vars.make
+++ b/make/lilypond-vars.make
@@ -51,7 +51,7 @@ $(LANG_TEXIDOC_FLAGS) \
 ifeq ($(USE_EXTRACTPDFMARK),yes)
 LILYPOND_BOOK_LILYPOND_FLAGS+= \
 -dfont-export-dir=$(top-build-dir)/out-fonts \
--dgs-never-embed-fonts
+-dgs-never-embed-fonts -b
 endif

 ifdef QUIET_BUILD
Index: make/lysdoc-targets.make
diff --git a/make/lysdoc-targets.make b/make/lysdoc-targets.make
index 547614cbd5164842da94832aa7123a841e51fe02..43f1babf04a21851a38a0c1ee5192a6cfd46e862 100644
--- a/make/lysdoc-targets.make
+++ b/make/lysdoc-targets.make
@@ -17,7 +17,7 @@ local-test:
                (cd $(top-src-dir) && git diff ) ; \
        fi > $(outdir)/tree.gittxt
 ifeq ($(USE_EXTRACTPDFMARK),yes)
- $(MAKE) LILYPOND_BOOK_LILYPOND_FLAGS="-dbackend=eps --formats=ps $(LILYPOND_JOBS) -dseparate-log-files -dinclude-eps-fonts -dgs-load-fonts --header=texidoc -I $(top-src-dir)/Documentation/included/ -ddump-profile -dcheck-internal-types -ddump-signatures -danti-alias-factor=1 -dfont-export-dir=$(top-build-dir)/out-fonts -dgs-never-embed-fonts" LILYPOND_BOOK_WARN= $(outdir)/collated-files.html LYS_OUTPUT_DIR=$(top-build-dir)/out/lybook-testdb + $(MAKE) LILYPOND_BOOK_LILYPOND_FLAGS="-dbackend=eps --formats=ps $(LILYPOND_JOBS) -dseparate-log-files -dinclude-eps-fonts -dgs-load-fonts --header=texidoc -I $(top-src-dir)/Documentation/included/ -ddump-profile -dcheck-internal-types -ddump-signatures -danti-alias-factor=1 -dfont-export-dir=$(top-build-dir)/out-fonts -dgs-never-embed-fonts -b" LILYPOND_BOOK_WARN= $(outdir)/collated-files.html LYS_OUTPUT_DIR=$(top-build-dir)/out/lybook-testdb
 else
$(MAKE) LILYPOND_BOOK_LILYPOND_FLAGS="-dbackend=eps --formats=ps $(LILYPOND_JOBS) -dseparate-log-files -dinclude-eps-fonts -dgs-load-lily-fonts --header=texidoc -I $(top-src-dir)/Documentation/included/ -ddump-profile -dcheck-internal-types -ddump-signatures -danti-alias-factor=1" LILYPOND_BOOK_WARN= $(outdir)/collated-files.html LYS_OUTPUT_DIR=$(top-build-dir)/out/lybook-testdb
 endif





reply via email to

[Prev in Thread] Current Thread [Next in Thread]