[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Standardize format of `in_color` (issue 329140043 by address@hidden)
|
From: |
beauleetienne0 |
|
Subject: |
Re: Standardize format of `in_color` (issue 329140043 by address@hidden) |
|
Date: |
Wed, 13 Sep 2017 17:32:13 -0700 |
Done. Changed other occurrences too.
https://codereview.appspot.com/329140043/diff/1/lily/axis-group-interface.cc
File lily/axis-group-interface.cc (right):
https://codereview.appspot.com/329140043/diff/1/lily/axis-group-interface.cc#newcode991
lily/axis-group-interface.cc:991: .in_color (1, 0, 1));
On 2017/09/10 10:27:06, dak wrote:
It's likely mostly a matter of taste but I'd lean towards using 1.0
and 0.0 here
since the arguments are of type Real and it makes it more obvious we
are indeed
talking about a fully bright color. Of course, same with all other
occurences.
Other than that, LGTM.
Acknowledged.
https://codereview.appspot.com/329140043/