Re: Let arpeggio-bracket/slur depend on grob-property thickness (issue 326970043 by address@hidden)

[thomasmorley65]

https://codereview.appspot.com/326970043/diff/1/lily/arpeggio.cc
File lily/arpeggio.cc (right):

https://codereview.appspot.com/326970043/diff/1/lily/arpeggio.cc#newcode192
lily/arpeggio.cc:192: Real lt = robust_scm2double (me->get_property
("thickness"), 0.1);
On 2017/07/28 23:12:37, Dan Eble wrote:
> 1. The "thickness" property is documented in
define-grob-properties.scm as being
> a multiple of the current staff line thickness. I'm having trouble
figuring out
> if that was also the case for what it is replacing.  Please confirm
whether
> using the raw thickness, rather than multiplying it by something, is
correct
> here.

As far as I can tell the printed thickness relied _only_ on staff line
thickness, without any possibility for the user to change it. Thus this
patch.
I now changed the used thickness to the multiplication of staff line
thickness and grob thickness.

For the slur-style arpeggio I'm not sure. One could change it to use
grob.line-thickness _and_ grob.thickness as it is done for Slur.

Opinions?

> 2. Add the default thickness to define-grobs.scm?

Done.

https://codereview.appspot.com/326970043/diff/1/lily/arpeggio.cc#newcode251
lily/arpeggio.cc:251: /* properties */
On 2017/07/28 23:12:37, Dan Eble wrote:
> Update this list.

Done.

https://codereview.appspot.com/326970043/